Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protobuf v3.4.0 sha update #18030

Closed
wants to merge 1 commit into from
Closed

protobuf v3.4.0 sha update #18030

wants to merge 1 commit into from

Conversation

mikz
Copy link

@mikz mikz commented Sep 13, 2017

protobuf sha changed protocolbuffers/protobuf#3619 (comment) and the new one is : f6600abeee3babfa18591961a0ff21e7db6a6d9ef82418a261ec4fee44ee6d44

Error: SHA256 mismatch
Expected: cd55ee08e64a86cf12aaadd4672961813f592c194ed0c9ad94da0ec75acf219f
Actual: f6600abeee3babfa18591961a0ff21e7db6a6d9ef82418a261ec4fee44ee6d44

Verified downloading the file from GitHub again.

  • Have you followed the guidelines for contributing?

  • Have you checked that there aren't other open pull requests for the same formula update/change?

  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?

  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

    • stable: sha256 changed without the version also changing; please create an issue upstream to rule out malicious circumstances and to find out why the file changed.

Not sure why the SHA256 changed, but the new one is f6600abeee3babfa18591961a0ff21e7db6a6d9ef82418a261ec4fee44ee6d44

Error: SHA256 mismatch
Expected: cd55ee08e64a86cf12aaadd4672961813f592c194ed0c9ad94da0ec75acf219f
Actual: f6600abeee3babfa18591961a0ff21e7db6a6d9ef82418a261ec4fee44ee6d44

Verified downloading the file from GitHub again.
@ilovezfs
Copy link
Contributor

This has to be reported to, and explained by, upstream before we merge it, in order to rule out malicious circumstances.

@mikz
Copy link
Author

mikz commented Sep 13, 2017

@ilovezfs I think it has been explained in protocolbuffers/protobuf#3619 (comment)

Actually it is not a change in upstream, but rather GitHub upgrading tar.
libgit2/libgit2#4343 (comment)

@ilovezfs
Copy link
Contributor

Thanks for reporting this @mikz and especially for linking to the libgit2 issue. This has been resolved in #18048.

@ilovezfs ilovezfs closed this Sep 14, 2017
@mikz mikz deleted the patch-1 branch September 14, 2017 08:24
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants