Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pldebugger 1.0 #19114

Closed
Closed

Conversation

felixbuenemann
Copy link
Sponsor Contributor

Bump pldebugger to the v1.0 tag, which points to the revision "ca1041dc3db6f516899be669dc6fbfd6339f8168" and is required for
compatibility with postgres 10.0.

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@felixbuenemann
Copy link
Sponsor Contributor Author

This is a related to the postgres 10.0 PR #19062.

@ilovezfs
Copy link
Contributor

ilovezfs commented Oct 7, 2017

@BrewTestBot test this please

Copy link
Contributor

@ilovezfs ilovezfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump pldebugger to the v1.0 tag

We should use :tag => + :revision => in the url

@felixbuenemann
Copy link
Sponsor Contributor Author

@ilovezfs But a tag is not immutable, and git sources do not have a sha256 checksum, so how do you ensure integrity in that case?

@ilovezfs
Copy link
Contributor

ilovezfs commented Oct 7, 2017

a tag is not immutable

Are they known to retag?

@ilovezfs
Copy link
Contributor

ilovezfs commented Oct 7, 2017

To be clear, we need something like this: https://github.com/Homebrew/homebrew-core/blob/master/Formula/osquery.rb#L5-L7

@felixbuenemann
Copy link
Sponsor Contributor Author

felixbuenemann commented Oct 7, 2017

No, but I thought the reason for using ˋ:revisionˋ was integrity. I have no problems with switching to a tag if that is not the goal.

@felixbuenemann
Copy link
Sponsor Contributor Author

Ah, using both tag and revision is fine.

Bump pldebugger to the v1.0 tag, which points to the revision
"ca1041dc3db6f516899be669dc6fbfd6339f8168" and is required for
compatibility with postgres 10.0.
@felixbuenemann
Copy link
Sponsor Contributor Author

@ilovezfs I've added :tag and removed the now redundant version "1.0" in 80e0816.

@ilovezfs ilovezfs closed this in 225597e Oct 7, 2017
@ilovezfs
Copy link
Contributor

ilovezfs commented Oct 7, 2017

Thanks @felixbuenemann!

@felixbuenemann felixbuenemann deleted the pldebugger-1.0 branch October 8, 2017 00:28
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants