pure-ftpd: fix launchd plist #20124
Merged
pure-ftpd: fix launchd plist #20124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct or document several install issues with pure-ftpd - plist requires each argument be added as an individual element [1] - add default users database location to plist configration [2] - document that service must be started as root [3] - `-` arguments replaced in plist with equivalent `--` arguments for better readability [1] https://apple.stackexchange.com/questions/284209/having-trouble-configuring-homebrew-to-run-pure-ftpd-as-a-service [2] https://github.com/jedisct1/pure-ftpd/issues/39 [3] https://github.com/jedisct1/pure-ftpd/issues/38
uriahcarpenter
changed the title
fix launchd plist
woodruffw
suggested changes
Nov 1, 2017
Formula/pure-ftpd.rb
Outdated
| @@ -40,6 +40,16 @@ def install | |||
| system "make", "install" | |||
| end | |||
|
|
|||
| def caveats | |||
There was a problem hiding this comment.
We prefer not to add new caveats to formulae, since they become outdated quickly and add to maintenance overhead.
There was a problem hiding this comment.
Removed caveat block.
uriahcarpenter
commented
Nov 2, 2017
Thanks! |
woodruffw
approved these changes
Nov 2, 2017
|
Thanks for your first contribution to Homebrew, @uriahcarpenter! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct or document several install issues with pure-ftpd
-arguments in plist with equivalent long--arguments for better readability [4][1] https://apple.stackexchange.com/questions/284209/having-trouble-configuring-homebrew-to-run-pure-ftpd-as-a-service
[2] https://github.com/jedisct1/pure-ftpd/issues/39
[3] https://github.com/jedisct1/pure-ftpd/issues/38
[4] https://download.pureftpd.org/pub/pure-ftpd/doc/README
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?