ocaml 4.06.0

[JCount]

Created with brew bump-formula-pr.

[JCount]

cc @ilovezfs

[JCount]

coccinelle and lablgtk are blocked on updating camlp4.

[ilovezfs]

This will fix OPAM: #20251

[ilovezfs]

This fixes the coccinelle test: 5063c2c

[ilovezfs]

This will fix lablgtk: #20252

[ilovezfs]

This will fix ocamlsdl: #20253

[ilovezfs]

🍏 but it seems to break a lot of the things with a build-time-only dependency so we may need to do some more surgery before merging.

[ilovezfs]

This gets coq building again: #20255

[ilovezfs]

ENV["OCAMLPARAM"] = "safe-string=0,_" seems to make most problems go away. So I think we can ship this.

[ilovezfs]

🍪

[ilovezfs]

• bibtex2html https://jenkins.brew.sh/job/Homebrew%20Testing/325/
  needs ENV["OCAMLPARAM"] = "safe-string=0,_"
• camlp4 https://jenkins.brew.sh/job/Homebrew%20Testing/326/
• camlp5 https://jenkins.brew.sh/job/Homebrew%20Testing/327/
• coccinelle https://jenkins.brew.sh/job/Homebrew%20Testing/328/
  needs ENV["OCAMLPARAM"] = "safe-string=0,_"
• compcert https://jenkins.brew.sh/job/Homebrew%20Testing/329/
  needs ocaml-num (compcert: depend on ocaml-num #20278)
• coq https://jenkins.brew.sh/job/Homebrew%20Testing/330/
  • needs camlp5 revision bumped (camlp5: revision for ocaml #20256)
  • needs ocaml-num (coq: depend on ocaml-num #20257)
• corectl https://jenkins.brew.sh/job/Homebrew%20Testing/331/
• docker-machine-driver-xhyve https://jenkins.brew.sh/job/Homebrew%20Testing/332/

Your request can't be satisfied:
  - No package matches qcow-format.

needs OCaml 4.05.0 from OPAM #20294

• flow https://jenkins.brew.sh/job/Homebrew%20Testing/333/
  broken, upstream report (OCaml 4.06.0 build failure facebook/flow#5270
  If we choose to resort to OCaml 4.05.0 from OPAM: flow: build with OCaml 4.05.0 from OPAM #20298

File "src/typing/flow_js.ml", line 10205, characters 2-334:
Error: This kind of expression is not allowed as right-hand side of `let rec'
Command exited with code 2.
make[1]: *** [build-flow] Error 10
make: *** [all-homebrew] Error 2

• fstar https://jenkins.brew.sh/job/Homebrew%20Testing/334/

==> opam config exec opam install batteries=2.7.0 zarith=1.5 yojson=1.4.0 pprint=20140424 stdint=0.4.2 menhir=20170712
[ERROR] pprint.20140424 is not available because your system doesn't comply
        with ocaml-version < "4.06".
[ERROR] batteries.2.7.0 is not available because your system doesn't comply
        with ocaml-version >= "3.12.1" & ocaml-version < "4.06.0".

needs OCaml 4.05.0 from OPAM #20293

• haxe https://jenkins.brew.sh/job/Homebrew%20Testing/335/
  needs ENV["OCAMLPARAM"] = "safe-string=0,_"
• hevea https://jenkins.brew.sh/job/Homebrew%20Testing/336/
• infer https://jenkins.brew.sh/job/Homebrew%20Testing/337/
• lablgtk https://jenkins.brew.sh/job/Homebrew%20Testing/338/
• ledit https://jenkins.brew.sh/job/Homebrew%20Testing/339/
  needs ENV["OCAMLPARAM"] = "safe-string=0,_"
• menhir https://jenkins.brew.sh/job/Homebrew%20Testing/340/
• mldonkey https://jenkins.brew.sh/job/Homebrew%20Testing/341/
  needs ocaml-num and needs ENV["OCAMLPARAM"] = "safe-string=0,_" (mldonkey: depend on ocaml-num at build time #20279)
• ocamlbuild https://jenkins.brew.sh/job/Homebrew%20Testing/342/
• ocamlsdl https://jenkins.brew.sh/job/Homebrew%20Testing/343/
• one-ml https://jenkins.brew.sh/job/Homebrew%20Testing/344/
  needs ENV["OCAMLPARAM"] = "safe-string=0,_"
• opam https://jenkins.brew.sh/job/Homebrew%20Testing/345/
• ott https://jenkins.brew.sh/job/Homebrew%20Testing/346/
• pdfsandwich https://jenkins.brew.sh/job/Homebrew%20Testing/347/
• ssreflect https://jenkins.brew.sh/job/Homebrew%20Testing/348/
  needs ENV["OCAMLPARAM"] = "safe-string=0,_"
• unison https://jenkins.brew.sh/job/Homebrew%20Testing/349/
  needs ENV["OCAMLPARAM"] = "safe-string=0,_"
• unison@2.40 https://jenkins.brew.sh/job/Homebrew%20Testing/350/
• zero-install https://jenkins.brew.sh/job/Homebrew%20Testing/351/
  needs ENV["OCAMLPARAM"] = "safe-string=0,_"

[shawwn]

Eh...

@ilovezfs FWIW, ocaml 4.06.0 wreaks havoc when attempting to build haxe from source.

To build haxe: make opam_install && make && make install

This works fine on older ocaml versions, but 4.06.0 fails to install various libraries during the make opam_install step.

This fixes most of the problems:

OCAMLPARAM="safe-string=0,_" make opam_install

However, opam install ptmap still fails. I had to run opam pin add ptmap path/to/my/monkeypatched/ptmap and fix the build issue in my local ptmap dir.

At that point haxe compiles successfully.

You can reproduce the issue:

brew install opam
brew unlink ocaml
opam switch 4.06.0
git clone https://github.com/HaxeFoundation/haxe
cd haxe
make opam_install # kaboom!
make && make install

Hope this helps!

[ilovezfs]

@shawwn yeah unsafe-string was enough for the current release version (see 7f64c31) but I haven't tried HEAD for haxe. Did you submit your monkey-patch for ptmap upstream?

[shawwn]

Nah, it's horrible. I don't know ocaml at all, so I did the bare minimum hack to get it to compile:

let rec update x f = function
    Empty ->
      begin match f None with
      | None -> Empty
      | Some data -> add x data empty
      end
    | Leaf (k,j) as t -> t
    | Branch (p,m,t0,t1) as t -> t

If you put that into ptmap.ml, it compiles and all the tests pass. But that update function is obviously bogus. It doesn't actually update anything.

The compile error was due to the fact that ptmap.ml has no update function, so the above snippet is just a way to sidestep the problem.

That only works because apparently nothing calls update. So even though the functionality is bogus, haxe still built successfully.

Good enough for me :P I'm out of time, so someone else will have to carry this from here.

[ilovezfs]

CC @andyli have you hit the above issue yet?

[shawwn]

ah, I see.. 7f64c31 you changed haxe's brew formula to set OCAMLPARAM="safe-string=0,_".

Makes sense. It might be good to add that OCAMLPARAM="safe-string=0,_" trick to haxe's makefile instead.

[ilovezfs]

@shawwn well really it needs to be fixed so that it works with safe-string on :)

[shawwn]

good luck! :) You'll have to submit patches to 3 or 4 opam repos. e.g. rope fails to install without that safe-string workaround.

[ilovezfs]

@shawwn yeah the whole ecosystem is going to take time to catch up.

[avsm]

It's unfortunate that this got merged so quickly. We're working hard on getting opam-repository to be compliant with safe-string, but it does take a few weeks to work through all the libraries. In the meanwhile, upgrading to 4.06.0 does break users as a result.

[ilovezfs]

@avsm we merge stable versions of each package as soon as they're green for our CI.

[ilovezfs]

@avsm my suggestion would be that you ship an opam version 1.2.3 that sets OCAMLPARAM="safe-string=0,_" in the environment until such time as the opam repository is actually caught up.