emacs: Add option to enable dynamic modules. #2263
Conversation
As of version 25.0.95 Emacs supports dynamic (native code) modules, but they are disabled by default. The `--with-modules` option must be passed to the `./configure` script to enable them. This commit adds this option to the formula, and warns the user if they try to use it for pre-25.0.95 builds. Note that when Emacs 25 is released, this option will be available to all builds, and the formula will need to be updated.
|
I'm reasonably reluctant to carrying around head/devel options only, truth be told. Feelings on this @dunn? |
| @@ -87,6 +88,14 @@ def install | |||
| args << "--with-imagemagick" if build.with? "imagemagick" | |||
| args << "--without-popmail" if build.with? "mailutils" | |||
|
|
|||
| if build.with? "modules" | |||
There was a problem hiding this comment.
You can probably just condense this into:
args << "--with-modules" if !build.stable && build.with?("modules")If we decide we're happy with this.
Yeah, we should probably wait until 25 is stable. That should be within a month or two anyway. |
|
I think that's a reasonable response. The one comment that I would make is that the community is now starting to try and build dynamic modules in preparation for 25's release, and this patch would make that much, much easier on Mac (where I believe most installs are through Homebrew). |
|
Will reconsider this when 25 is stable, thanks. |
brew install <formula>(where<formula>is the name of the formula you're submitting)?brew audit --strict --online <formula>(after doingbrew install <formula>)?As of version 25.0.95 Emacs supports dynamic (native code) modules, but they are disabled by default. The
--with-modulesoption must be passed to the./configurescript to enable them. This PR addsthis option to the formula, and warns the user if they try to use it for pre-25.0.95 builds.
Note that when Emacs 25 is released, this option will be available to all builds, and the formula will need to be updated.