Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grv 0.1.1 (new formula) #23627

Closed
wants to merge 1 commit into from
Closed

grv 0.1.1 (new formula) #23627

wants to merge 1 commit into from

Conversation

rgburke
Copy link
Contributor

@rgburke rgburke commented Feb 3, 2018

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@ilovezfs
Copy link
Contributor

ilovezfs commented Feb 4, 2018

This is running go get https://github.com/rgburke/grv/blob/master/Makefile#L33 which is not permitted in Homebrew. The resources will need to be vendored upstream with a vendor directory and/or using dep, glide or the like. See mitchellh/gox#102 for an example.

Thanks for the PR nonetheless, though, @rgburke. Feel free to open a fresh PR when upstream vendoring has been implemented in a new release.

@ilovezfs ilovezfs closed this Feb 4, 2018
@ilovezfs ilovezfs added go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core labels Feb 4, 2018
@rgburke
Copy link
Contributor Author

rgburke commented Feb 4, 2018

@ilovezfs Thank you for taking the time to look at the PR and for providing feedback. I will make the changes you have described and open a fresh PR.

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants