Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3 3.5.2 #2415

Closed
wants to merge 7 commits into from
Closed

python3 3.5.2 #2415

wants to merge 7 commits into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Jun 27, 2016

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same formula update/change?
  • Have you built your formula locally prior to submission with brew install <formula> (where <formula> is the name of the formula you're submitting)?
  • Does your submission pass brew audit --strict --online <formula> (after doing brew install <formula>)?

https://www.python.org/downloads/release/python-352/ Also upgrades setuptools, pip, and wheel

Fails when applying Homebrew/python3--patch

==> Downloading https://homebrew.bintray.com/bottles/python3-3.5.2.el_capitan.bottle.3.tar.gz

curl: (22) The requested URL returned error: 404 Not Found
Error: Failed to download resource "python3"
Download failed: https://homebrew.bintray.com/bottles/python3-3.5.2.el_capitan.bottle.3.tar.gz
Warning: Bottle installation failed: building from source.
==> Downloading https://www.python.org/ftp/python/3.5.2/Python-3.5.2.tar.xz
Already downloaded: /Users/cclauss/Library/Caches/Homebrew/python3-3.5.2.tar.xz
==> Downloading https://bugs.python.org/file40478/xcode-stubs.diff
Already downloaded: /Users/cclauss/Library/Caches/Homebrew/python3--patch-029cc0dc72b1bcf4ddc5f913cc4a3fd970378073c6355921891f041aca2f8b12.diff
==> Patching
==> Applying xcode-stubs.diff
patching file Lib/distutils/ccompiler.py
Hunk #1 FAILED at 875.
1 out of 1 hunk FAILED -- saving rejects to file Lib/distutils/ccompiler.py.rej
patching file Lib/distutils/unixccompiler.py
Hunk #1 FAILED at 76.
Hunk #2 FAILED at 257.
Hunk #3 FAILED at 277.
Hunk #4 FAILED at 286.
Hunk #5 FAILED at 294.
5 out of 5 hunks FAILED -- saving rejects to file Lib/distutils/unixccompiler.py.rej
Error: Failure while executing: /usr/bin/patch -g 0 -f -p1 -i /private/tmp/python3--patch-20160627-47816-92pvb8/xcode-stubs.diff

cclauss added 3 commits June 27, 2016 05:35
@apetresc
Copy link
Contributor

apetresc commented Jun 27, 2016

The patch that is failing to apply is no longer required. It was applied upstream (the only difference between the patch in this formula and the upstream commit is that the upstream commit also added some comments explaining it).

The formula seems to build fine for me by removing that patch.

The patch that is failing to apply is no longer required. It was
[applied upstream](python/cpython@6e0963c)
(the only difference between the [patch in this
formula](https://bugs.python.org/file40478/xcode-stubs.diff) and the
upstream commit is that the upstream commit also added some comments
explaining it).

The formula seems to build fine for me by removing that patch.
@tdsmith
Copy link
Contributor

tdsmith commented Jun 27, 2016

Looks good once the patch is removed. I'll plan to squash these into a single commit with the title python3 3.5.2; you can do that yourself if you like.

@cclauss
Copy link
Contributor Author

cclauss commented Jun 27, 2016

Hi Tim, If you could do that, it would be great. My git skills are pretty weak.

@tdsmith
Copy link
Contributor

tdsmith commented Jun 27, 2016

Sure thing. Please go ahead and push another commit to this branch removing the patch. Thanks!

@rakkesh
Copy link
Contributor

rakkesh commented Jun 27, 2016

could you update devel block with the latest alpha release,

devel do
  url "https://www.python.org/ftp/python/3.6.0/Python-3.6.0a2.tar.xz"
  sha256 "2dd2ddf22a63ef9642a20b1f5a40983209e8d7a8ad8371a881fde520edc9ff86"
end

@tdsmith
Copy link
Contributor

tdsmith commented Jun 27, 2016

I'll do that on pull; thanks for noticing the new alpha release.

@tdsmith
Copy link
Contributor

tdsmith commented Jun 27, 2016

I'm not sure those URLs for setuptools and wheel are correct; can you verify?

@apetresc
Copy link
Contributor

I believe they're wrong. I have a fixed patch that passes tests on cclauss/homebrew-core#1, if @cclauss just merges it, everything should be fine.

Remove unneeded patch from Python-3.5.2 formula.
@sashkab
Copy link
Contributor

sashkab commented Jun 28, 2016

FYI: You can use new URL for packages:

https://pypi.io/packages/source/v/virtualenv/virtualenv-15.0.2.tar.gz

where:

  • v - first letter of the package
  • virtualenv - package name
  • virtualenv-15.0.2.tar.gz - file name to download.

From what I heard, this is how it will work from now on. There are cons and pros for this.

Pros:

  • URL alway will point to the tar.gz you pointing to.

Cons:

  • You won't know if tar.gz was replaced, as this link will always point to the latest version (ie same version, but file was updated)

@tdsmith
Copy link
Contributor

tdsmith commented Jun 28, 2016

You won't know if tar.gz was replaced, as this link will always point to the latest version (ie same version, but file was updated)

FWIW, pypi doesn't allow files to be replaced, so this shouldn't be a concern.

@tdsmith
Copy link
Contributor

tdsmith commented Jun 28, 2016

@tdsmith
Copy link
Contributor

tdsmith commented Jun 28, 2016

confirm fixed by Homebrew/brew#400

@cclauss
Copy link
Contributor Author

cclauss commented Jun 28, 2016

In the meantime Python 2.7.12 was released https://www.python.org/downloads/release/python-2712/. See: PR #2452

@woodruffw
Copy link
Member

Sorry for the build chaos over here 🙇

@cclauss
Copy link
Contributor Author

cclauss commented Jun 28, 2016

@woodruffw Is the test failing above a problem for this PR on not?

@woodruffw
Copy link
Member

@cclauss Not anymore, only earlier.

@cclauss
Copy link
Contributor Author

cclauss commented Jun 28, 2016

@woodruffw Your meaning of your response is not clear to me. The formula works on my Mac but the test above is failing. Does the test failure above (on PyQT5 ??) mean that there is a problem with this PR?

@woodruffw
Copy link
Member

woodruffw commented Jun 28, 2016

@cclauss Sorry for the confusion. A commit not related to your formula (Homebrew/brew/pull/400) was merged prematurely, causing your build failure. That commit was reverted, and I've restarted your build on the CI. There's nothing wrong with your PR AFAICT.

@tdsmith
Copy link
Contributor

tdsmith commented Jun 28, 2016

To extend @woodruffw's remarks: we need some version of Homebrew/brew#400 to land before this PR will succeed, so this won't pass just yet, but the PR itself is still fine.

@DomT4 DomT4 added bug Reproducible Homebrew/homebrew-core bug in progress Stale bot should stay away labels Jun 29, 2016
@UniqMartin UniqMartin changed the title Upgrade to Python 3.5.2 python3 3.5.2 Jun 29, 2016
@UniqMartin
Copy link
Contributor

Restarted the build after Homebrew/brew#400 had landed and looks like the bug has been properly resolved this time. I guess this PR can be merged if @tdsmith is happy with this.

@UniqMartin UniqMartin removed the bug Reproducible Homebrew/homebrew-core bug label Jun 29, 2016
@tdsmith tdsmith closed this in f377ed1 Jun 29, 2016
@BrewTestBot BrewTestBot removed the in progress Stale bot should stay away label Jun 29, 2016
@tdsmith
Copy link
Contributor

tdsmith commented Jun 29, 2016

Thanks for your patience, everyone!

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants