Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unbound 1.7.0 #25403

Closed
wants to merge 1 commit into from
Closed

unbound 1.7.0 #25403

wants to merge 1 commit into from

Conversation

JCount
Copy link
Contributor

@JCount JCount commented Mar 17, 2018

Created with brew bump-formula-pr.

@fxcoudert
Copy link
Member

@BrewTestBot test this please

@fxcoudert
Copy link
Member

for x in testdata/*.rpl; do echo -n "$x "; if ./testbound -p $x >/dev/null 2>&1; then echo OK; else echo failed; exit 1; fi done
-n testdata/acl.rpl 
OK
-n testdata/auth_xfr.rpl 
OK
-n testdata/auth_xfr_host.rpl 
OK
-n testdata/auth_xfr_ixfr.rpl 
failed
make: *** [test] Error 1

@JCount
Copy link
Contributor Author

JCount commented Mar 24, 2018

Yes, make test is failing that test, but it is difficult to ascertain what, and how much, significance that failure has.

cc @ilovezfs for thoughts/opinion.

@Habbie
Copy link
Contributor

Habbie commented Mar 31, 2018

The breakage was introduced in NLnetLabs/unbound@172b84f. It does work on Debian 9 so it's probably a portability issue. (There are more portability issues with the tests but they apparently did not break things before).

@Habbie
Copy link
Contributor

Habbie commented Mar 31, 2018

[3600] unbound[91909:0] error: mismatch in file /tmp/testbound_91909_temp_example.com.tmp, line 9
[3600] unbound[91909:0] error: file has : mail.example.com.	3600	IN	AAAA	::0.0.0.5
[3600] unbound[91909:0] error: should be: mail.example.com.	3600	IN	AAAA	::5

this is a long standing bug in the macOS libc, if I recall correctly.

@Habbie
Copy link
Contributor

Habbie commented Mar 31, 2018

Working formula: https://gist.github.com/Habbie/9403f6bd280caf2ec414f9a42b61ff3b

It adds the patch :DATA line, and the patch at the end. The patch :DATA probably needs some comments before homebrew will accept this.

@Habbie
Copy link
Contributor

Habbie commented Mar 31, 2018

Upstream workaround submitted at https://www.nlnetlabs.nl/bugs-script/show_bug.cgi?id=4043 in the hope the next release will then not need patch :DATA any more.

@Habbie
Copy link
Contributor

Habbie commented Apr 3, 2018

Upstream has merged the patch.

@JCount
Copy link
Contributor Author

JCount commented Apr 3, 2018

@Habbie Thanks for the info! 👍 😄 (and upstream bug report)

@ilovezfs
Copy link
Contributor

ilovezfs commented Apr 4, 2018

@BrewTestBot test this please or else

@JCount
Copy link
Contributor Author

JCount commented Apr 4, 2018

😡

@JCount JCount closed this in aebcb71 Apr 4, 2018
@JCount JCount deleted the unbound-1.7.0 branch April 4, 2018 01:52
@lock lock bot added the outdated PR was locked due to age label May 4, 2018
@lock lock bot locked as resolved and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants