espeak: fix build #2726
espeak: fix build #2726
Conversation
Patched to compile static and dynamic libraries (libespeak.*) and added docs to share.install
|
@danielbair Just FYI: you don't need to resubmit PRs on changes: you can just push commits to them. It's also worth using a non-
In this case I think it's probably worth just removing this project/formula file from Homebrew instead of patching it. |
|
@MikeMcQuaid Hi, I would like to suggest to keep the eSpeak formula, as no official version of eSpeak-ng has been released yet, and eSpeak is still a popular choice for people looking for a free software TTS, plus third party projects (including a couple of mine) depend on it. Personally, I am planning to switch to eSpeak-ng only after the new lead developer of that project releases an official/packaged version --- right now one has to get and compile the dev sources. |
dunn
added
the
marked for removal/rejection
|
Sorry, I don't think we'll merge this as-is if it needs this much patching.
@pettarin That seems reasonable. |
Disable #define USE_ASYNC to compile for OS X. Found solution from the developer from this (https://sourceforge.net/p/espeak/discussion/538922/thread/0d957467/#407 d) discussion.
|
@MikeMcQuaid will you re-consider merging with the patches only being four lines now? |
| -#define USE_ASYNC | ||
| -#endif | ||
| +//#ifdef LIBRARY | ||
| +//#define USE_ASYNC |
There was a problem hiding this comment.
Could just comment out this single line.
|
@danielbair It's looking better now. Could you try to use |
|
@MikeMcQuaid I have modified to use |
dunn
removed
the
marked for removal/rejection
Patched to build static and dynamic libraries with needed changes 'per brew audit' now.
Please note: upstream development is dead on the espeak project from my research.
A new project named espeak-ng is progressing with new developers, but this is needed for the older espeak project and other projects that link against the old espeak.