Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fork-cleaner 1.3.0 (new formula) #27805

Closed
wants to merge 2 commits into from
Closed

fork-cleaner 1.3.0 (new formula) #27805

wants to merge 2 commits into from

Conversation

MikeMcQuaid
Copy link
Member

  • This is technically not notable enough but it's useful and easily packaged.
  • The revision is to allow people to upgrade from the upstream tap. It can be removed if that's undesirable.
  • The test can't really be more complex as it needs GitHub API tokens to do any more.

@ilovezfs ilovezfs added the new formula PR adds a new formula to Homebrew/homebrew-core label May 14, 2018
@ilovezfs
Copy link
Contributor 

==> dep ensure
dep: WARNING: unknown field in manifest: dependencies

That should be reported.

@ilovezfs ilovezfs added the audit failure CI fails while auditing the software label May 14, 2018
@ilovezfs ilovezfs added the upstream issue An upstream issue report is needed label May 14, 2018
@ilovezfs
Copy link
Contributor

🍴

@ilovezfs ilovezfs closed this in b6edc8d May 14, 2018
@MikeMcQuaid MikeMcQuaid deleted the fork-cleaner branch May 14, 2018 08:53
@MikeMcQuaid
Copy link
Member Author

🍴

I spent ages cleaning those, thanks a LOT.

(thanks for the merge 😉)

@MikeMcQuaid MikeMcQuaid mentioned this pull request May 14, 2018
Closed
@MikeMcQuaid
Copy link
Member Author

That should be reported.

Done so: caarlos0/fork-cleaner#12

@ilovezfs
Copy link
Contributor

Thanks!

caarlos0 added a commit to caarlos0/fork-cleaner that referenced this pull request May 14, 2018
@caarlos0
docs: using brew core
2dd255b 
refs Homebrew/homebrew-core#27805
@lock lock bot added the outdated PR was locked due to age label Jun 13, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jun 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ilovezfs ilovezfs ilovezfs approved these changes

Assignees
No one assigned
Labels
audit failure CI fails while auditing the software new formula PR adds a new formula to Homebrew/homebrew-core outdated PR was locked due to age upstream issue An upstream issue report is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MikeMcQuaid @ilovezfs