Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

activemq: Adding plist again, addressing #39477 #2825

Closed
wants to merge 1 commit into from

Conversation

douglasjose
Copy link
Contributor

  • [:white_check_mark:] Have you followed the guidelines in our Contributing document?
  • [:white_check_mark:] Have you checked to ensure there aren't other open Pull Requests for the same formula update/change?
  • [:white_check_mark:] Have you built your formula locally prior to submission with brew install <formula> (where <formula> is the name of the formula you're submitting)?
  • [:white_check_mark:] Does your submission pass brew audit --strict --online <formula> (after doing brew install <formula>)?

activemq: Adding plist configured with AbandonProcessGroup=true, addressing original issue in #39477.

@dunn
Copy link
Contributor

dunn commented Jul 9, 2016

Thanks! Merged as 6cafb22.

@dunn dunn closed this in 6cafb22 Jul 9, 2016
<key>AbandonProcessGroup</key>
<true/>
<key>WorkingDirectory</key>
<string>#{libexec}</string>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have probably been opt_libexec, or we're going to have the same problem where the plist needs unloading, replacing & reloading every revision/update.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries 😃

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants