purescript 0.9.2

[ilovezfs]

needed to patch ambiguous occurrence errors

[schrepfler]

Any idea why this broke on the CI server, commit seems OK as I would have thought to commit it (sha matches).

[ilovezfs]

[115 of 137] Compiling Language.PureScript.Ide.Pursuit ( src/Language/PureScript/Ide/Pursuit.hs, dist/dist-sandbox-175d3357/build/Language/PureScript/Ide/Pursuit.o )

src/Language/PureScript/Ide/Pursuit.hs:56:32: error:
    Ambiguous occurrence ‘fromStrict’
    It could refer to either ‘Protolude.fromStrict’,
                             imported from ‘Protolude’ at src/Language/PureScript/Ide/Pursuit.hs:22:1-26
                             (and originally defined in ‘Data.Text.Lazy’)
                          or ‘Data.ByteString.Lazy.fromStrict’,
                             imported from ‘Data.ByteString.Lazy’ at src/Language/PureScript/Ide/Pursuit.hs:26:49-58

src/Language/PureScript/Ide/Pursuit.hs:68:30: error:
    Ambiguous occurrence ‘fromStrict’
    It could refer to either ‘Protolude.fromStrict’,
                             imported from ‘Protolude’ at src/Language/PureScript/Ide/Pursuit.hs:22:1-26
                             (and originally defined in ‘Data.Text.Lazy’)
                          or ‘Data.ByteString.Lazy.fromStrict’,
                             imported from ‘Data.ByteString.Lazy’ at src/Language/PureScript/Ide/Pursuit.hs:26:49-58

Probably due to a new version of one of deps.

[ilovezfs]

@schrepfler It's a regression introduced by purescript/purescript@8063c4d

This fixes it:

diff --git a/src/Language/PureScript/Ide/Pursuit.hs b/src/Language/PureScript/Ide/Pursuit.hs
index 9032a34..d7164fa 100644
--- a/src/Language/PureScript/Ide/Pursuit.hs
+++ b/src/Language/PureScript/Ide/Pursuit.hs
@@ -19,7 +19,7 @@ module Language.PureScript.Ide.Pursuit
   , findPackagesForModuleIdent
   ) where

-import           Protolude
+import           Protolude hiding (fromStrict)

 import qualified Control.Exception             as E
 import           Data.Aeson
diff --git a/src/Language/PureScript/Ide/Util.hs b/src/Language/PureScript/Ide/Util.hs
index 4e4c235..7ccf217 100644
--- a/src/Language/PureScript/Ide/Util.hs
+++ b/src/Language/PureScript/Ide/Util.hs
@@ -27,7 +27,7 @@ module Language.PureScript.Ide.Util
   , module Language.PureScript.Ide.Conversions
   ) where

-import           Protolude
+import           Protolude hiding (decodeUtf8, encodeUtf8)
 import           Data.Aeson
 import qualified Data.Text                     as T
 import           Data.Text.Lazy.Encoding       (decodeUtf8, encodeUtf8)

[schrepfler]

So what's the plan, commit upstream and wait for new tag?

[ilovezfs]

@schrepfler no, I've opened an upstream PR and will apply it as a patch to this PR in the next few minutes: purescript/purescript#2225

[ilovezfs]

@DomT4 PR refreshed.

@schrepfler you can try it locally if you do brew pull 2905

[DomT4]

@ilovezfs 👍 when you're happy. LGTM. Thanks for filing a PR upstream as well!

[schrepfler]

Are we merging it then?

[ilovezfs]

@schrepfler sure. The issues being discussed with upstream regarding the PR are about bumping their Stack requirements which has no effect over here so I'll just refresh this once that's set in stone, hopefully with a new tag too.

[ilovezfs]

@schrepfler 🚢'd

[ilovezfs]

Woo hoo upstream PR just merged! purescript/purescript@15c466f