-
-
Notifications
You must be signed in to change notification settings - Fork 12.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ansi 1.0.0 (new formula) #29139
ansi 1.0.0 (new formula) #29139
Conversation
Formula/ansi.rb
Outdated
desc "This bash script is designed to help you colorize words and bits of text" | ||
homepage "https://github.com/fidian/ansi" | ||
url "https://github.com/fidian/ansi.git", | ||
:using => :git, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line can be removed.
Formula/ansi.rb
Outdated
homepage "https://github.com/fidian/ansi" | ||
url "https://github.com/fidian/ansi.git", | ||
:using => :git, | ||
:revision => "3624905213bd89f1023c1190df25069acc14abd5" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We require a tagged release, not just a commit. Also, tarballs are preferred over git checkouts unless they are needed for a reason, e.g. submodules.
As the most recent tag is almost two years old I suggest that you ask upstream to tag a new release.
end | ||
|
||
test do | ||
system "#{bin}/ansi", "--help" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test needs to exercise and verify the functionality of the software.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm working on this atm. The utility outputs ansi escaped strings, and I'm having difficulty capturing the escape codes from stdout to do a compare.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
brew install --build-from-source ansi
, whereansi
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install ansi
)?