Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansi 1.0.0 (new formula) #29139

Closed
wants to merge 3 commits into from
Closed

ansi 1.0.0 (new formula) #29139

wants to merge 3 commits into from

Conversation

drewsonne
Copy link

@drewsonne drewsonne commented Jun 17, 2018

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source ansi, where ansi is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install ansi)?

@drewsonne drewsonne changed the title Add formula for ansi utility ansi 1.0.0 Jun 17, 2018
@commitay commitay changed the title ansi 1.0.0 ansi 1.0.0 (new formula) Jun 17, 2018
Formula/ansi.rb Outdated
desc "This bash script is designed to help you colorize words and bits of text"
homepage "https://github.com/fidian/ansi"
url "https://github.com/fidian/ansi.git",
:using => :git,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line can be removed.

Formula/ansi.rb Outdated
homepage "https://github.com/fidian/ansi"
url "https://github.com/fidian/ansi.git",
:using => :git,
:revision => "3624905213bd89f1023c1190df25069acc14abd5"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We require a tagged release, not just a commit. Also, tarballs are preferred over git checkouts unless they are needed for a reason, e.g. submodules.

As the most recent tag is almost two years old I suggest that you ask upstream to tag a new release.

end

test do
system "#{bin}/ansi", "--help"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test needs to exercise and verify the functionality of the software.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm working on this atm. The utility outputs ansi escaped strings, and I'm having difficulty capturing the escape codes from stdout to do a compare.

@commitay commitay added the new formula PR adds a new formula to Homebrew/homebrew-core label Jun 17, 2018
@drewsonne drewsonne mentioned this pull request Jun 21, 2018
@stale
Copy link

stale bot commented Jul 14, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale No recent activity label Jul 14, 2018
@stale stale bot closed this Jul 21, 2018
@lock lock bot added the outdated PR was locked due to age label Aug 20, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new formula PR adds a new formula to Homebrew/homebrew-core outdated PR was locked due to age stale No recent activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants