-
-
Notifications
You must be signed in to change notification settings - Fork 12.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lepton 1.2.1 (new formula) #3012
Conversation
Other than expected audit problem, El Cap:
Mavericks and Yosemite:
Any insight? I don't see this locally, and this is wandering into the hardware domain which I have absolutely no idea of. |
Reported upstream: dropbox/lepton#11. |
|
||
def install | ||
# Wrong header, fixed in https://github.com/dropbox/lepton/commit/d122450 | ||
inreplace "src/vp8/util/memory.cc", "<emmintrin.h>", "<immintrin.h>" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That patch is simply this inreplace plus an irrelevant typo fix in README, so I figured there's no reason to add another download.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Patches are a bit more self-documenting and tend to get removed more readily when not needed so if you could remove it that'd be great.
I've applied a big patch that brings the whole package to latest git master which is dropbox/lepton@acfb6ae. It's not intended for shipping; I just to need to test some upstream fixes and/or improvements on the test bot. |
4a240d0
to
e4da5f9
Compare
Bumped to 1.2. |
We're making good progress here: builds on Mavericks and Yosemite now pass. There's still a (new) problem on El Cap, which I reported upstream in a new issue: dropbox/lepton#28. |
ae2560d
to
7ac2417
Compare
@MikeMcQuaid Everything is now sorted out in 1.2.1. Guess we'll just wait for the 30 days mark, or maybe an exception could be made due to popularity (~3000 stars in three days)? |
brew install <formula>
(where<formula>
is the name of the formula you're submitting)?brew audit --strict --online <formula>
(after doingbrew install <formula>
)?This file format and tool is newly open sourced. See
https://blogs.dropbox.com/tech/2016/07/lepton-image-compression-saving-22-losslessly-from-images-at-15mbs/.
It doesn't pass audit at the moment because the GitHub repo is too new, but the code base itself is by no means new — initial commit dates back to June 2015. And Dropbox being Dropbox this repo is quickly gaining traction (500+ stars at time of writing, < 1 day after the blog post).
If the formula isn't acceptable at this point, I'll just leave it around and bump it in a month.