Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Valgrind cavheat highsierra #30490

Closed

Conversation

MartinDelille
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

I simply added a cavheat information for 10.13 users.

@SMillerDev
Copy link
Member

Why does valgrind require HEAD with High Sierra?

@MartinDelille
Copy link
Contributor Author

Because current valgrind release don't support it. More information here:

Changing the repository URL doesn't seems to be necessary.

@SMillerDev
Copy link
Member

Afaik as a rule homebrew doesn't suggest using the head option of a formula as it requires compiling everything on the machine. @ilovezfs any opinions?

@ilovezfs
Copy link
Contributor

Upstream should do a release. Has anyone asked for one? Given how close macOS Mojave is to release, and the current stable version of valgrind is not High Sierra compatible, we're nearing deletion territory for the formula at this point.

@MartinDelille
Copy link
Contributor Author

I will ask.

@MartinDelille
Copy link
Contributor Author

@Echelon9
Copy link

Valgrind's upstream MacOS maintainer here.
Preliminary work is being undertaken to prepare for Valgrind's next numbered release. Unfortunately I don't have a specific date that I can communicate, but it is in train.
Appreciate this might not be the immediate answer you wanted -- but thought best to get it out there.
Thanks for the interest.

@SMillerDev
Copy link
Member

Will that release work on mojave? Or no idea about that yet?

@Echelon9
Copy link

Very unlikely to have Mojave support in any Valgrind release (other than git Valgrind) at the time of Mojave's public release.

The issue we face is that Valgrind needs to tie fairly closely into the mach kernel syscalls. And these are added to/changed each major macOS release. And we can't release the Valgrind code supporting any changes until the public release of macOS version "n" happens, as otherwise we're breaching the pre-release T&Cs.

We've been fairly good at get rudimentary macOS "n" support into git versions within a month or so of public release, but it's not reasonable to expect the prior Valgrind numbered release will support the new macOS version ahead of time.
Does that help with guidance?

@fxcoudert
Copy link
Member

Thanks for suggesting the caveat @MartinDelille.
Given the information given by upstream, I think we'll decline the caveat: we typically don't suggest building from head, and hopefully a new release is here soon!

@fxcoudert fxcoudert closed this Aug 5, 2018
@lock lock bot added the outdated PR was locked due to age label Sep 4, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Sep 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants