Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

krakend 0.6.0 #31887

Closed
wants to merge 2 commits into from
Closed

krakend 0.6.0 #31887

wants to merge 2 commits into from

Conversation

alombarte
Copy link
Contributor

Created with brew bump-formula-pr.

@fxcoudert
Copy link
Member 

==> make build
Building the binary...
# github.com/devopsfaith/krakend-ce
github.com/devopsfaith/krakend-ce/vendor/github.com/tmthrgd/go-hex.encodeASM: relocation target runtime.support_avx not defined
github.com/devopsfaith/krakend-ce/vendor/github.com/tmthrgd/go-memset.memsetAsm: relocation target runtime.support_avx not defined
make: *** [build] Error 2

@alombarte
Copy link
Contributor Author

Ooops

The referenced vendor does not work with the latest Go version (1.11), need to use 1.10.3 ...

@fxcoudert fxcoudert mentioned this pull request Sep 16, 2018
Closed
@fxcoudert fxcoudert closed this in 62631a3 Sep 16, 2018
alombarte
alombarte commented Oct 5, 2018
View reviewed changes
Formula/krakend.rb
@@ -13,7 +13,7 @@ class Krakend < Formula
end

depends_on "dep" => :build
depends_on "go" => :build
depends_on "go@1.10" => :build
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should be reverted, as the release requires 1.11

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alombarte if the new version build with go, we would welcome a pull request

@lock lock bot added the outdated PR was locked due to age label Nov 4, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Nov 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fxcoudert fxcoudert fxcoudert left review comments

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alombarte @fxcoudert