Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sfk 1.9.3.2 #33315

Closed
wants to merge 1 commit into from
Closed

sfk 1.9.3.2 #33315

wants to merge 1 commit into from

Conversation

Moisan
Copy link
Member

@Moisan Moisan commented Oct 23, 2018

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

brew bump-formula-pr complained that both version were 1.9.2.0.

@fxcoudert fxcoudert mentioned this pull request Oct 23, 2018
9 tasks
@Moisan
Copy link
Member Author

Moisan commented Oct 23, 2018

@BrewTestBot test this please

@Moisan
Copy link
Member Author

Moisan commented Oct 24, 2018

checking whether the C++ compiler works... no
configure: error: in `/private/tmp/sfk-20181023-1997-16147oo/sfk-1.9.3':
configure: error: C++ compiler cannot create executables

@Moisan
Copy link
Member Author

Moisan commented Nov 2, 2018

Removing ENV.libstdcxx passes the configure but fails at make with errors similar to the ones previously seen in #18878.

@SMillerDev
Copy link
Member

@fxcoudert made that one, any opinions here?

@SMillerDev SMillerDev added the build failure CI fails while building the software label Nov 21, 2018
@stale
Copy link

stale bot commented Dec 12, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale No recent activity label Dec 12, 2018
@stale stale bot closed this Dec 20, 2018
@Moisan Moisan added the not merged PR was closed without being merged (and may need to be revisited) label Dec 20, 2018
@lock lock bot added the outdated PR was locked due to age label Jan 20, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
build failure CI fails while building the software not merged PR was closed without being merged (and may need to be revisited) outdated PR was locked due to age stale No recent activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants