Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with missing --with-dynamics option in vault #34089

Closed
wants to merge 1 commit into from

Conversation

Mazorius
Copy link
Contributor

@Mazorius Mazorius commented Nov 15, 2018

Signed-off-by: Ron Gebauer ron.gebauer@valtech.com

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Signed-off-by: Ron Gebauer <ron.gebauer@valtech.com>
@fxcoudert
Copy link
Member

fxcoudert commented Nov 15, 2018

Thanks for the pull request.

We are not going to add that option back, for reasons explained here: #33507 (comment)

@fxcoudert fxcoudert closed this Nov 15, 2018
@Mazorius
Copy link
Contributor Author

Hi @fxcoudert ,

I do not found a solution which I can use otherwise.
If I set the environment variable CGO_ENABLED=1 the vault installation does not work as well.

Do you know a solution for that problem?

Best regards

@icebourg
Copy link

We were dependent on the --with-dynamic option, this is a major 👎 for home brew.

@Mazorius
Copy link
Contributor Author

Hi @icebourg ,

Since I was not allowed to add this, I built a script as a workaround. This adapts the .md file and installs vault with dev-dynamic.

#!/usr/bin/env bash

set -x

SCRIPT_PATH=$(dirname $0)/

cp "/usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/vault.rb" ${SCRIPT_PATH}
sed -i -e 's/"dev"/"dev-dynamic"/' ${SCRIPT_PATH}vault.rb

brew uninstall --force vault
brew install --build-from-source ${SCRIPT_PATH}vault.rb

rm ${SCRIPT_PATH}vault.rb

@lock lock bot added the outdated PR was locked due to age label Dec 26, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Dec 26, 2018
@Mazorius Mazorius deleted the vault-with-dynamics-fix branch April 19, 2021 12:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants