Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sqlite: remove options and caveats. #36073

Merged
merged 1 commit into from Jan 21, 2019
Merged

sqlite: remove options and caveats. #36073

merged 1 commit into from Jan 21, 2019

Conversation

MikeMcQuaid
Copy link
Member

See #31510

@fxcoudert
Copy link
Member

Oops… I just realised I overrode that PR in my commit 7789d6f

@MikeMcQuaid the reason I didn't include functions in my commit is that instructions to load that module are rather complicated. If it does not work "out of the box", I don't think we should include it. (And it's not that widely used, really)

@lembacon
Copy link
Member

@fxcoudert But I think we should include FTS.

@MikeMcQuaid
Copy link
Member Author

@fxcoudert Cool. Omitting functions and leaving the rest.

@MikeMcQuaid MikeMcQuaid mentioned this pull request Jan 21, 2019
Merged
@MikeMcQuaid
Copy link
Member Author

mps-youtube test is working locally so assuming https://jenkins.brew.sh/job/Homebrew%20Core%20Pull%20Requests/36546/#showFailuresLink was a blip.

theharvester test being fixed in #36208.

@MikeMcQuaid MikeMcQuaid merged commit 29d769c into Homebrew:master Jan 21, 2019
@MikeMcQuaid MikeMcQuaid deleted the sqlite-remove-options branch January 21, 2019 10:39
@lock lock bot added the outdated PR was locked due to age label Feb 20, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MikeMcQuaid @fxcoudert @lembacon