Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imagemagick: add rsvg support #36773

Closed
wants to merge 1 commit into from

Conversation

hjmallon
Copy link
Contributor

@hjmallon hjmallon commented Feb 6, 2019

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

I would like to add rsvg to imagemagic as without is svg->png conversions don't work. It was pretty popular (similar to HEIF I think which was accepted).

https://formulae.brew.sh/formula/imagemagick

@hjmallon hjmallon changed the title iimagemagick: add rsvg support imagemagick: add rsvg support Feb 6, 2019
@fxcoudert
Copy link
Member

Hum… librsvg has huge dependency tree:

$ brew deps --tree librsvg
librsvg
├── cairo
│   ├── fontconfig
│   │   └── freetype
│   │       └── libpng
│   ├── freetype
│   │   └── libpng
│   ├── glib
│   │   ├── gettext
│   │   ├── libffi
│   │   └── pcre
│   ├── libpng
│   └── pixman
├── gdk-pixbuf
│   ├── glib
│   │   ├── gettext
│   │   ├── libffi
│   │   └── pcre
│   ├── jpeg
│   ├── libpng
│   └── libtiff
│       └── jpeg
├── glib
│   ├── gettext
│   ├── libffi
│   └── pcre
├── libcroco
│   └── glib
│       ├── gettext
│       ├── libffi
│       └── pcre
└── pango
    ├── cairo
    │   ├── fontconfig
    │   │   └── freetype
    │   │       └── libpng
    │   ├── freetype
    │   │   └── libpng
    │   ├── glib
    │   │   ├── gettext
    │   │   ├── libffi
    │   │   └── pcre
    │   ├── libpng
    │   └── pixman
    ├── fontconfig
    │   └── freetype
    │       └── libpng
    ├── fribidi
    ├── glib
    │   ├── gettext
    │   ├── libffi
    │   └── pcre
    └── harfbuzz
        ├── cairo
        │   ├── fontconfig
        │   │   └── freetype
        │   │       └── libpng
        │   ├── freetype
        │   │   └── libpng
        │   ├── glib
        │   │   ├── gettext
        │   │   ├── libffi
        │   │   └── pcre
        │   ├── libpng
        │   └── pixman
        ├── freetype
        │   └── libpng
        ├── glib
        │   ├── gettext
        │   ├── libffi
        │   └── pcre
        ├── graphite2
        └── icu4c

@hjmallon
Copy link
Contributor Author

hjmallon commented Feb 8, 2019

True, I leave it up to you. I can always keep my git in a branch locally for this use.

I think new deps would be something like

cairo
fontconfig
fribidi
gdk-pixbuf
gettext
glib
graphite2
harfbuzz
icu4c
libcroco
libffi
pango
pcre
pixman

@fxcoudert fxcoudert added the maintainer feedback Additional maintainers' opinions may be needed label Feb 8, 2019
@javian
Copy link
Contributor

javian commented Feb 10, 2019

I would tend to agree that the dependency list is too big to include . I can see the need for it but there are also other tools that does the same with less of a footprint.

@fxcoudert
Copy link
Member

Thanks @hjmallon for suggesting this, we are going to decline.

@fxcoudert fxcoudert closed this Feb 10, 2019
@lock lock bot added the outdated PR was locked due to age label Mar 12, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 12, 2019
@hjmallon hjmallon deleted the imagemagick.rsvg branch March 14, 2020 17:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintainer feedback Additional maintainers' opinions may be needed outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants