poac 0.1.2 (new formula) #36880
Closed
poac 0.1.2 (new formula) #36880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
@fxcoudert |
fxcoudert
requested changes
Feb 12, 2019
Formula/poac.rb
Outdated
| depends_on "yaml-cpp" | ||
|
|
||
| def install | ||
| mkdir "bulid" do |
|
|
||
| def install | ||
| mkdir "bulid" do | ||
| system "cmake", "..", *std_cmake_args |
There was a problem hiding this comment.
Somehow it looks like it is hardcoding the compiler path?
/usr/local/opt/llvm/bin/clang++ -DPOAC_PROJECT_ROOT=\"/tmp/poac-20190211-22098-1vavzz3\" -DPOAC_VERSION=\"0.1.2\" -I/usr/local/include -I/usr/local/opt/openssl/include -std=c++17 -pthread -I/usr/local/opt/llvm/include -DNDEBUG -fdiagnostics-color -Wall -Wextra -Werror -o CMakeFiles/poac.dir/main.cpp.o -c /tmp/poac-20190211-22098-1vavzz3/main.cpp
make[2]: /usr/local/opt/llvm/bin/clang++: No such file or directory
make[2]: *** [CMakeFiles/poac.dir/main.cpp.o] Error 1
There was a problem hiding this comment.
I get the following error in case of no hardcoding the compiler path.
Call to unavailable function 'visit': introduced in macOS 10.14
Therefore, if macOS is not 10.14, able to build by using to llvm.
| end | ||
|
|
||
| test do | ||
| assert_match /Usage/, shell_output("#{bin}/poac --help") |
There was a problem hiding this comment.
We need a test that exercises the some of the functionality of the app.
|
@fxcoudert |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?