Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xdelta as dependency to snapcraft formula #39022

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@mgrachev
Copy link
Contributor

commented Apr 17, 2019

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Hi there!

When I tried to push a snap package via snapcraft, I got the error:

A tool snapcraft depends on could not be found: 'xdelta3'.
Ensure the tool is installed and available, and try again.
Sorry, an error occurred in Snapcraft:
Traceback (most recent call last):
  File "/usr/local/bin/snapcraft", line 11, in <module>
    load_entry_point('snapcraft==3.0.1', 'console_scripts', 'snapcraft')()
  File "/usr/local/Cellar/snapcraft/3.0.1/libexec/lib/python3.7/site-packages/snapcraft/cli/__main__.py", line 81, in run
    run_snapcraft(prog_name="snapcraft")
  File "/usr/local/Cellar/snapcraft/3.0.1/libexec/lib/python3.7/site-packages/click/core.py", line 722, in __call__
    return self.main(*args, **kwargs)
  File "/usr/local/Cellar/snapcraft/3.0.1/libexec/lib/python3.7/site-packages/click/core.py", line 697, in main
    rv = self.invoke(ctx)
  File "/usr/local/Cellar/snapcraft/3.0.1/libexec/lib/python3.7/site-packages/click/core.py", line 1066, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/local/Cellar/snapcraft/3.0.1/libexec/lib/python3.7/site-packages/click/core.py", line 895, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/local/Cellar/snapcraft/3.0.1/libexec/lib/python3.7/site-packages/click/core.py", line 535, in invoke
    return callback(*args, **kwargs)
  File "/usr/local/Cellar/snapcraft/3.0.1/libexec/lib/python3.7/site-packages/snapcraft/cli/store.py", line 161, in push
    snapcraft.push(snap_file, channel_list)
  File "/usr/local/Cellar/snapcraft/3.0.1/libexec/lib/python3.7/site-packages/snapcraft/_store.py", line 552, in push
    result = _push_delta(snap_name, snap_filename, source_snap)
  File "/usr/local/Cellar/snapcraft/3.0.1/libexec/lib/python3.7/site-packages/snapcraft/_store.py", line 595, in _push_delta
    source_path=source_snap, target_path=target_snap
  File "/usr/local/Cellar/snapcraft/3.0.1/libexec/lib/python3.7/site-packages/snapcraft/internal/deltas/_xdelta3.py", line 28, in __init__
    delta_tool_path = file_utils.get_tool_path("xdelta3")
  File "/usr/local/Cellar/snapcraft/3.0.1/libexec/lib/python3.7/site-packages/snapcraft/file_utils.py", line 355, in get_tool_path
    raise ToolMissingError(command_name=command_name)
snapcraft.internal.errors.ToolMissingError: A tool snapcraft depends on could not be found: 'xdelta3'.

So, I added xdelta as a dependency to the snapcraft formula.

@fxcoudert

This comment has been minimized.

Copy link
Member

commented Apr 17, 2019

Thanks @mgrachev

@fxcoudert fxcoudert closed this in 663d2f2 Apr 17, 2019

@mgrachev mgrachev deleted the mgrachev:add-snapcraft-dependency branch Apr 17, 2019

@lock lock bot added the outdated label May 17, 2019

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.