gcc: patch and revision for Xcode bug

[zbeekman]

• See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89864

• See also https://discourse.brew.sh/t/atomic-does-not-name-a-type-gcc8-should-be-updated-patched/4516/

• Have you followed the guidelines for contributing?

• Have you checked that there aren't other open pull requests for the same formula update/change?

• Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?

• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?

• Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

---

I'm still building and testing locally, please do not merge yet.

This is a work around for an Xcode bug, introduced in the latest Xcode release.

See:

• https://discourse.brew.sh/t/atomic-does-not-name-a-type-gcc8-should-be-updated-patched/4516/
• https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89864

[zbeekman]

Local build finished, and tests pass locally.

I think this is ready to 🚢 unless other maintainers want changes.

[fxcoudert]

• Sad that Apple, once again, does not care about compilers other than clang
• OK on principle, but please put the patch on formula-patches and include it in a patch do block
• Thanks for taking care of this!

[zbeekman]

hmmm.... the patch recommended by the GCC devs didn't apply cleanly. I'll use the old patch instead...

[zbeekman]

reverted the patch at formula-patches to the user contributed one from the forums: https://discourse.brew.sh/t/atomic-does-not-name-a-type-gcc8-should-be-updated-patched/4516/10

[zbeekman]

@BrewTestBot test this please

[rjurney]

Seeing this problem on the latest (as of 4/18/19) version of Mac OS X Mojave (10.14.4) and XCode (10.2.1 (10E1001)). brew install gccproduced an error and pointed me here. I'm unable to build python-geohash as a result.

[EdmundMai]

Same, brew install postgis brought me here

[zbeekman]

@rjurney and @EdmundMai when you guys are running brew install <formula> is it building from source? By default you should be getting bottled gcc and postgis. If you build gcc from source it will fail until this is merged, and other C++ projects built with gcc may also fail until this is merged.

As soon as CI is green (we don't have binary bottles to merge until then) this will get merged and should resolve your issue, assuming it's the error related to _Atomic...

[EdmundMai]

@zbeekman correct, it says it's building from source:

brew install postgis
==> Installing dependencies for postgis: gcc, szip, hdf5, jasper, json-c, libxml2, libdap, proj, libgeotiff, libpng, libpq, libspatialite, netcdf, openblas, python@2, numpy, freetype, fontconfig, gettext, libffi, glib, pixman, cairo, little-cms2, nspr, nss, openjpeg, qt, poppler, libtool, unixodbc, webp, xerces-c, zstd, gdal, protobuf, protobuf-c, boost, eigen, cgal and sfcgal
==> Installing postgis dependency: gcc
Warning: Building gcc from source:
  The bottle needs the Xcode CLT to be installed.
==> Downloading https://ftp.gnu.org/gnu/gcc/gcc-8.3.0/gcc-8.3.0.tar.xz
Already downloaded: /Users/edmundmai/Library/Caches/Homebrew/downloads/790ecda70af93e36763edcb183a8d4e91e433bee9bad9a60360addae9d8e82be--gcc-8.3.0.tar.xz
==> ../configure --build=x86_64-apple-darwin18.2.0 --prefix=/usr/local/Cellar/gcc/8.3.0 --libdir=/usr/local/Cellar/gcc/8.3.0/lib/gcc/8 --disabl
==> make BOOT_LDFLAGS=-Wl,-headerpad_max_install_names

[SMillerDev]

With that log, installing the commandline tools should be enough to have it use bottles.

[fxcoudert]

Two test failures to address: libmatio and nwchem

• New bottles for libmatio should fix it: 34b1bdd
• Trying to fix nwchem: nwchem: fix test #39091

[fxcoudert]

@zbeekman can you look at applying the same fix to gcc@6 and gcc@7 please? see #38553

[zbeekman]

sure!

[petitout]

Hi @zbeekman,
seems like it is still not merged.
meanwhile I tried :

brew remove gcc
brew tap androidports/patch
brew install -s androidports/patch/gcc

without success. I still have _atomic issue...
Any idea ?

[zbeekman]

@petitout: Why are you tapping androidports/patch? This is now in homebrew-core.

If you need additional support please ask in discourse.brew.sh and include relavent logs and output of brew doctor.

For now try:

xcode-select --install # ensure you have xcode CLT
brew untap androidports/patch
brew update-reset
brew upgrade gcc

If that doesn't work, please post over on discourse.brew.sh