use secure urls and other minor fixes #3 (part 1) #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vszakats
changed the title
| @@ -3,7 +3,7 @@ class Astyle < Formula | |||
| homepage "http://astyle.sourceforge.net/" | |||
| url "https://downloads.sourceforge.net/project/astyle/astyle/astyle%202.05.1/astyle_2.05.1_macosx.tar.gz" | |||
| sha256 "de66da286dee2b9de1dc1c05092cbf5368c0889f25d1e2ee8b51766aff8e4baf" | |||
| head "svn://svn.code.sf.net/p/astyle/code/trunk/AStyle" | |||
| head "https://svn.code.sf.net/p/astyle/code/trunk/AStyle" | |||
There was a problem hiding this comment.
These SVN changes will probably need to be reverted I'm afraid. We've historically used either svn:// or http:// because the system svn can't handle automatic SSL/TLS connections and we're not interested in mandating people install Homebrew's SVN just to do SVN checkouts. Example:
Error validating server certificate for 'https://svn.code.sf.net:443':
- The certificate is not issued by a trusted authority. Use the
fingerprint to validate the certificate manually!
Certificate information:
- Hostname: *.code.sf.net
- Valid: from Wed, 06 Apr 2016 00:00:00 GMT until Mon, 05 Jun 2017 23:59:59 GMT
- Issuer: GeoTrust Inc., US
- Fingerprint: 9c:63:de:5c:24:c4:86:ed:d2:53:26:e1:26:6b:52:0d:dd:b0:95:a3
(R)eject, accept (t)emporarily or accept (p)ermanently?
There was a problem hiding this comment.
Thanks, they were a suspect. I'll revert them.
ghost
removed
the
vszakats
changed the title
|
Merging without CI run since these are just HTTPS changes. Manual review looks good. Merged. Thank you for your contribution to Homebrew! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew audit --strict --online <formula>(where<formula>is the name of the formula you're submitting)?brew install <formula>?