Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] glassfish 5.1.0 #39700

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@chenrui333
Copy link
Contributor

commented May 12, 2019

No description provided.

@fxcoudert

This comment has been minimized.

Copy link
Member

commented May 12, 2019

@BrewTestBot test this please

@chenrui333

This comment has been minimized.

Copy link
Contributor Author

commented May 12, 2019

09:03:03 ==> Installing 'bundler' gem
09:03:03 Successfully installed bundler-2.0.1
09:03:03 1 gem installed
09:03:03 Error: 1 problem in 1 formula detected
09:03:03 glassfish:
09:03:03   * C: 4: col 3: Use GitHub tarballs rather than zipballs (url is https://github.com/eclipse-ee4j/glassfish/archive/5.1.0.zip).
09:03:03 
09:03:03 ==> brew style glassfish

@chenrui333 chenrui333 force-pushed the chenrui333:glassfish-5.1.0 branch from f92cf8f to 9cb31bd May 12, 2019

@chenrui333

This comment has been minimized.

Copy link
Contributor Author

commented May 12, 2019

Thanks for the update change!

@@ -1,8 +1,8 @@
class Glassfish < Formula
desc "Open Source Jakarta EE Platform Implementation"
homepage "https://eclipse-ee4j.github.io/glassfish/"
url "https://www.eclipse.org/downloads/download.php?file=/glassfish/glassfish-5.1.0.zip&mirror_id=518"i

This comment has been minimized.

Copy link
@chenrui333

chenrui333 May 12, 2019

Author Contributor

I dont think you can make that change, it missed the bin folder which is needed to boot up an application server for java apps.
image

@chenrui333 chenrui333 changed the title glassfish 5.1.0 [wip] glassfish 5.1.0 May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.