Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wip] glassfish 5.1.0 #39700

Closed
wants to merge 2 commits into from
Closed

[wip] glassfish 5.1.0 #39700

wants to merge 2 commits into from

Conversation

chenrui333
Copy link
Member

No description provided.

@fxcoudert
Copy link
Member

@BrewTestBot test this please

@chenrui333
Copy link
Member Author 

09:03:03 ==> Installing 'bundler' gem
09:03:03 Successfully installed bundler-2.0.1
09:03:03 1 gem installed
09:03:03 Error: 1 problem in 1 formula detected
09:03:03 glassfish:
09:03:03   * C: 4: col 3: Use GitHub tarballs rather than zipballs (url is https://github.com/eclipse-ee4j/glassfish/archive/5.1.0.zip).
09:03:03 
09:03:03 ==> brew style glassfish

@chenrui333
Copy link
Member Author

Thanks for the update change!

chenrui333
chenrui333 commented May 12, 2019
View reviewed changes
Formula/glassfish.rb Outdated
@@ -1,8 +1,8 @@
class Glassfish < Formula
desc "Open Source Jakarta EE Platform Implementation"
homepage "https://eclipse-ee4j.github.io/glassfish/"
url "https://www.eclipse.org/downloads/download.php?file=/glassfish/glassfish-5.1.0.zip&mirror_id=518"i
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think you can make that change, it missed the bin folder which is needed to boot up an application server for java apps.
image

@chenrui333 chenrui333 changed the title glassfish 5.1.0 [wip] glassfish 5.1.0 May 16, 2019
SMillerDev
SMillerDev reviewed Jun 25, 2019
View reviewed changes
Formula/glassfish.rb Outdated
sha256 "85450f0cd4875729d64be6bcbf7ed8f61009ea0f23d3be453c6f3d1dbab02420"
desc "Open Source Jakarta EE Platform Implementation"
homepage "https://eclipse-ee4j.github.io/glassfish/"
url "https://www.eclipse.org/downloads/download.php?file=/glassfish/glassfish-5.1.0.zip&mirror_id=518"i
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the I doing there and should we specify a mirror?

@SMillerDev SMillerDev added the build failure CI fails while building the software label Jun 25, 2019
@chenrui333
Copy link
Member Author

@SMillerDev, I sort of understand your perspective now, the glassfish project has transferred the ownership, now it becomes painful to make the change, I am going to close it now. As I has been quite a while.

@chenrui333 chenrui333 closed this Aug 15, 2019
@lock lock bot added the outdated PR was locked due to age label Jan 15, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 15, 2020
@chenrui333 chenrui333 deleted the glassfish-5.1.0 branch December 18, 2022 04:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SMillerDev SMillerDev SMillerDev left review comments

Assignees
No one assigned
Labels
build failure CI fails while building the software outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chenrui333 @fxcoudert @SMillerDev