-
-
Notifications
You must be signed in to change notification settings - Fork 12.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
terraform 0.7.2 #4237
terraform 0.7.2 #4237
Conversation
Raised hashicorp/terraform#8489 for this. |
@ojongerius awesome, thank you. I'll switch this over to tag+revision instead of url+sha256 until upstream has a fix. |
1104d43
to
6dc9f11
Compare
I filed the bug yesterday for this here Sorry for not getting back to this side of things. Was busy and just ignored the one error locally. |
Is this getting merged in soon? @ilovezfs |
@conord33 need this fixed 1st if you'd like to nudge someone about it hashicorp/terraform#8489 (comment) |
im on it |
thank u! |
Is there any movement on this? I'm looking to use 0.7.2, now. |
I'm 👍 whenever this is 💚 |
@MikeMcQuaid: Is there a way to restart this build? I tried locally using this commit/patch, and the bottle builds fine. Not sure what Jenkins is failing on as the build link 404s (I'm guessing the job was cleaned up). |
@BrewTestBot test this please |
I'm not sure what is up with Jenkins and this build. In my last comment, the bottle I built was on 10.9 as there was mention in the other PR that it was the one failing. Jenkins was able to build that one too. However, it's failing on Yosemite and El Capitan. I have to rebuild my Yosemite vagrant box, so I can't test that right away.. but I was able to build this bottle on El Capitan successfully using the following: cd $(brew --repository)/Library/Taps/homebrew/homebrew-core/
curl https://github.com/ilovezfs/homebrew-core/commit/6dc9f11.patch | git apply -
brew install --build-bottle --verbose terraform I'm running 10.11.6 (El Capitan) + go1.7. I note that Jenkins doesn't seem to mention the go version in it's configuration section, so I'm not sure what it's running. |
@cblecker seems to be a problem with parallelized builds. |
2812c9b
to
bbf777b
Compare
@ilovezfs That seems to have fixed El Capitan and Yosemite, but Mavericks is back to failing, with the same error that El Capitan was failing on. 😞 |
@cblecker yes I tried limiting the scope to the |
@cblecker these were the successful runs, not the one you were looking at Now trying it above the whole hashicorp section since moving it below the go test section still led to a failure. |
a1fb22a
to
32a2750
Compare
It seems that scoping the deparallelization to the build of golang.org/x/tools/cmd/stringer is sufficient, which is somewhat surprising since the failures occur later. It may be that it's silently producing a defective stringer binary if this continues to hold up as a fix. |
Awesome, ready to merge? |
deparallelize the build of golang.org/x/tools/cmd/stringer, which seems to be defective otherwise, causing subsequent failures in the terraform build, though the exact mechanism by which that occurs isn't yet clear
32a2750
to
18a92ef
Compare
@ojongerius shipped! |
🎉 |
deparallelize the build of golang.org/x/tools/cmd/stringer, which seems
to be defective otherwise, causing subsequent failures in the terraform
build, though the exact mechanism by which that occurs isn't yet clear