Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terraform 0.7.2 #4237

Closed
wants to merge 1 commit into from
Closed

terraform 0.7.2 #4237

wants to merge 1 commit into from

Conversation

ilovezfs
Copy link
Contributor

@ilovezfs ilovezfs commented Aug 25, 2016

deparallelize the build of golang.org/x/tools/cmd/stringer, which seems
to be defective otherwise, causing subsequent failures in the terraform
build, though the exact mechanism by which that occurs isn't yet clear

@BrewTestBot BrewTestBot added the in progress Stale bot should stay away label Aug 25, 2016
@ojongerius
Copy link
Contributor

Raised hashicorp/terraform#8489 for this.

@ilovezfs
Copy link
Contributor Author

@ojongerius awesome, thank you. I'll switch this over to tag+revision instead of url+sha256 until upstream has a fix.

@Techcadia
Copy link

I filed the bug yesterday for this here Sorry for not getting back to this side of things. Was busy and just ignored the one error locally.

@conord33
Copy link

Is this getting merged in soon? @ilovezfs

@ilovezfs
Copy link
Contributor Author

@conord33 need this fixed 1st if you'd like to nudge someone about it hashicorp/terraform#8489 (comment)

@conord33
Copy link

im on it

@ilovezfs
Copy link
Contributor Author

thank u!

@dustyburwell
Copy link

Is there any movement on this? I'm looking to use 0.7.2, now.

@dunn dunn added the upstream issue An upstream issue report is needed label Sep 3, 2016
@MikeMcQuaid
Copy link
Member

I'm 👍 whenever this is 💚

@cblecker
Copy link
Contributor

cblecker commented Sep 4, 2016

@MikeMcQuaid: Is there a way to restart this build? I tried locally using this commit/patch, and the bottle builds fine. Not sure what Jenkins is failing on as the build link 404s (I'm guessing the job was cleaned up).

@dunn
Copy link
Contributor

dunn commented Sep 4, 2016

@BrewTestBot test this please

@dunn dunn added the CI-requeued PR has been re-added to the queue label Sep 4, 2016
@cblecker
Copy link
Contributor

cblecker commented Sep 4, 2016

I'm not sure what is up with Jenkins and this build. In my last comment, the bottle I built was on 10.9 as there was mention in the other PR that it was the one failing. Jenkins was able to build that one too. However, it's failing on Yosemite and El Capitan. I have to rebuild my Yosemite vagrant box, so I can't test that right away.. but I was able to build this bottle on El Capitan successfully using the following:

cd $(brew --repository)/Library/Taps/homebrew/homebrew-core/
curl https://github.com/ilovezfs/homebrew-core/commit/6dc9f11.patch | git apply -
brew install --build-bottle --verbose terraform

I'm running 10.11.6 (El Capitan) + go1.7. I note that Jenkins doesn't seem to mention the go version in it's configuration section, so I'm not sure what it's running.

@ilovezfs
Copy link
Contributor Author

ilovezfs commented Sep 4, 2016

@cblecker seems to be a problem with parallelized builds.

@cblecker
Copy link
Contributor

cblecker commented Sep 4, 2016

@ilovezfs That seems to have fixed El Capitan and Yosemite, but Mavericks is back to failing, with the same error that El Capitan was failing on. 😞

@ilovezfs
Copy link
Contributor Author

ilovezfs commented Sep 4, 2016

@cblecker yes I tried limiting the scope to the "go", "test", section, so it's likely after that then.

@ilovezfs
Copy link
Contributor Author

ilovezfs commented Sep 4, 2016

@cblecker these were the successful runs, not the one you were looking at
https://bot.brew.sh/job/Homebrew%20Core%20Pull%20Requests/7195/
https://bot.brew.sh/job/Homebrew%20Core%20Pull%20Requests/7198/

Now trying it above the whole hashicorp section since moving it below the go test section still led to a failure.

@ilovezfs
Copy link
Contributor Author

ilovezfs commented Sep 5, 2016

It seems that scoping the deparallelization to the build of golang.org/x/tools/cmd/stringer is sufficient, which is somewhat surprising since the failures occur later. It may be that it's silently producing a defective stringer binary if this continues to hold up as a fix.

@ojongerius
Copy link
Contributor

Awesome, ready to merge?

deparallelize the build of golang.org/x/tools/cmd/stringer, which seems
to be defective otherwise, causing subsequent failures in the terraform
build, though the exact mechanism by which that occurs isn't yet clear
@ilovezfs ilovezfs closed this in bd19c77 Sep 5, 2016
@BrewTestBot BrewTestBot removed the in progress Stale bot should stay away label Sep 5, 2016
@ilovezfs
Copy link
Contributor Author

ilovezfs commented Sep 5, 2016

@ojongerius shipped!

@ojongerius
Copy link
Contributor

🎉

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-requeued PR has been re-added to the queue upstream issue An upstream issue report is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants