Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Todolist 0.3.0 #4298

Closed
wants to merge 1 commit into from
Closed

Todolist 0.3.0 #4298

wants to merge 1 commit into from

Conversation

gammons
Copy link
Contributor

@gammons gammons commented Aug 28, 2016

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same formula update/change?
  • Have you built your formula locally prior to submission with brew install <formula> (where <formula> is the name of the formula you're submitting)?
  • Does your submission pass brew audit --new-formula <formula> (after doing brew install <formula>)?

@DomT4
Copy link
Member

DomT4 commented Aug 28, 2016

Do the resources need updating at all? Is there any plan to start vendoring those upstream in future, out of curiosity?

@DomT4 DomT4 added go Go use is a significant feature of the PR or issue needs response Needs a response from the issue/PR author labels Aug 28, 2016
@gammons
Copy link
Contributor Author

gammons commented Aug 28, 2016

Hi Dominyk,

The change to the actual todolist binary was very minor. The bigger change was what todolist web would serve.

I'm happy to look into vendoring resources. I looked at the homebrew docs but couldn't find specifics on how to do that. If you could point me in the right direction I'd really appreciate it.

@ghost ghost removed the needs response Needs a response from the issue/PR author label Aug 28, 2016
@DomT4
Copy link
Member

DomT4 commented Aug 28, 2016

I'm happy to look into vendoring resources. I looked at the homebrew docs but couldn't find specifics on how to do that. If you could point me in the right direction I'd really appreciate it.

It's not a Homebrew thing as such, but rather a dependency system Golang have been trying to nudge developers of Go projects into, and because it makes packaging easier & more consistent for everyone we've been trying to ask as well. Very much not mandatory, but it's a nice system for stability.

The Golang wiki goes into a fair chunk of detail. Govendor is nice & simple. gvt is even simpler than govendor.

@apjanke
Copy link
Contributor

apjanke commented Aug 31, 2016

Any objection to merging this as is, and switching to vendored resources in a different PR?

@DomT4
Copy link
Member

DomT4 commented Aug 31, 2016

Interested still if the resources need a bump. If they don't need a bump, sure 👍.

The way go get (still) works on non-vendored projects is to just go get the tip of the master branch (in 99.9% of cases) of the dependencies, so it's nice to try & keep up with that so the experience of brew and outside brew for the same tool remains similar.

Saves upstream devs some work trying to chase up why one behaves differently from the other in bug reports, sometimes.

@gammons
Copy link
Contributor Author

gammons commented Aug 31, 2016

Hi @DomT4, @apjanke,

The resources do not need to be bumped. I'll definitely look into vendoring my resources for the next release.

@apjanke apjanke closed this in b8b3b40 Aug 31, 2016
@apjanke
Copy link
Contributor

apjanke commented Aug 31, 2016

Merged! Thank you for your contribution.

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
go Go use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants