Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new Formula, ossutil 1.6.6 #43857

Closed
wants to merge 3 commits into from
Closed

Conversation

alswl
Copy link
Contributor

@alswl alswl commented Sep 4, 2019

  • Have you followed the guidelines for contributing?

  • Have you checked that there aren't other open pull requests for the same formula update/change?

  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?

  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?

  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

  • brew audit --new-formula ossutil

  • except: "go_resources are deprecated. Please ask upstream to implement Go vendoring`"


@fxcoudert
Copy link
Member

  * C: 4: col 9: Description should start with a capital letter
  * C: 4: col 9: Description shouldn't start with an indefinite article, i.e. "a"
  * C: 13: col 3: `go_resource`s are deprecated. Please ask upstream to implement Go vendoring

@fxcoudert fxcoudert added the new formula PR adds a new formula to Homebrew/homebrew-core label Sep 4, 2019
@alswl
Copy link
Contributor Author

alswl commented Sep 5, 2019

  * C: 4: col 9: Description should start with a capital letter
  * C: 4: col 9: Description shouldn't start with an indefinite article, i.e. "a"
  * C: 13: col 3: `go_resource`s are deprecated. Please ask upstream to implement Go vendoring

Issues left are all about go_resource now, I will push upstream use vendoring. Can you merge this version to homebrew-core

@SMillerDev
Copy link
Member

We won't merge formula (especially new ones) with known issues. After this has been resolved upstream we can merge it.

@SMillerDev SMillerDev added almost there PR is nearly ready to merge do not merge labels Sep 5, 2019
@fxcoudert
Copy link
Member

I'm closing this for now, we'll be glad to consider a new PR with proper dep vendoring.

@fxcoudert fxcoudert closed this Sep 14, 2019
@lock lock bot added the outdated PR was locked due to age label Jan 9, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
almost there PR is nearly ready to merge new formula PR adds a new formula to Homebrew/homebrew-core outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants