Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update git-archive-all to 1.15 #4419

Closed
wants to merge 1 commit into from
Closed

Conversation

Kentzo
Copy link
Contributor

@Kentzo Kentzo commented Sep 1, 2016

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same formula update/change?
  • Have you built your formula locally prior to submission with brew install <formula> (where <formula> is the name of the formula you're submitting)?
  • Does your submission pass brew audit --new-formula <formula> (after doing brew install <formula>)?

@Kentzo
Copy link
Contributor Author

Kentzo commented Sep 1, 2016

How do I update bottle?

@MikeMcQuaid
Copy link
Member

@dunn dunn added the needs response Needs a response from the issue/PR author label Sep 2, 2016
@ilovezfs
Copy link
Contributor

ilovezfs commented Sep 4, 2016

@Kentzo the test can be fixed with this diff

diff --git a/Formula/git-archive-all.rb b/Formula/git-archive-all.rb
index 6b0ce32..c15dcf9 100644
--- a/Formula/git-archive-all.rb
+++ b/Formula/git-archive-all.rb
@@ -27,7 +27,7 @@ class GitArchiveAll < Formula
     system "git", "add", "homebrew"
     system "git", "commit", "--message", "brewing"

-    assert_equal "#{testpath}/homebrew => archive/homebrew",
+    assert_equal "#{testpath.realpath}/homebrew => archive/homebrew",
                  shell_output("#{bin}/git-archive-all --dry-run ./archive", 0).chomp
   end
 end

@ghost ghost removed the needs response Needs a response from the issue/PR author label Sep 13, 2016
@Kentzo
Copy link
Contributor Author

Kentzo commented Sep 20, 2016

@ilovezfs Was fixed by checks still fail.

@Kentzo
Copy link
Contributor Author

Kentzo commented Sep 22, 2016

Anyone?

@dunn
Copy link
Contributor

dunn commented Oct 2, 2016

@BrewTestBot test this please

@dunn
Copy link
Contributor

dunn commented Oct 2, 2016

Sorry for the delay! Merged as 488f523.

@dunn dunn closed this in 488f523 Oct 2, 2016
@Kentzo Kentzo deleted the git-archive-all branch March 2, 2017 22:53
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants