Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crc 1.3.0 (new formula) #46083

Closed
wants to merge 1 commit into from
Closed

crc 1.3.0 (new formula) #46083

wants to merge 1 commit into from

Conversation

cblecker
Copy link
Contributor

@cblecker cblecker commented Nov 1, 2019

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@fxcoudert fxcoudert added the new formula PR adds a new formula to Homebrew/homebrew-core label Nov 1, 2019
Formula/crc.rb Outdated Show resolved Hide resolved
Formula/crc.rb Outdated Show resolved Hide resolved
@fxcoudert
Copy link
Member

Looking at the webpage, I'm wondering about the additional constraints on this software:

Each released crc binary expires 30 days after the release due to certificates embedded in the Openshift cluster.

and

To use these binaries, please follow the instructions at https://cloud.redhat.com/openshift/install/crc/installer-provisioned to obtain the needed pull-secret

I'm wondering whether it makes sense for us shipping software with such restrictions.

@cblecker cblecker changed the title crc 1.0.0 (new formula) crc 1.3.0 (new formula) Dec 14, 2019
@cblecker
Copy link
Contributor Author

@fxcoudert any update on this? :)

@SMillerDev SMillerDev added the maintainer feedback Additional maintainers' opinions may be needed label Dec 15, 2019
@SMillerDev
Copy link
Member

@Homebrew/core I think those restrictions mean that this formula is better suited for a personal tap. Any other opinions?

@iMichka
Copy link
Member

iMichka commented Dec 15, 2019

If it means that someone needs to update the software here each 30 days, I would rather have it in a tap.

@MikeMcQuaid
Copy link
Member

@cblecker Can you elaborate on the above restrictions when you get a chance? Thanks!

@claui
Copy link
Contributor

claui commented Dec 15, 2019

If I understand the website correctly, the program now auto-updates certificates without needing recompilation.

The restriction quoted by @fxcoudert seems to be outdated and was corrected on the website a few days ago.

@cblecker
Copy link
Contributor Author

That is correct. The 30 day restriction was technical (certificate renewals internal to the virtual cluster), and has since been fixed. The current version (1.3.0) does not have this restriction.

@MikeMcQuaid
Copy link
Member

Thanks again so much for your contribution! Without people like you submitting PRs we couldn't run this project. You rock, @cblecker!

@cblecker cblecker deleted the crc branch December 16, 2019 17:45
@lock lock bot added the outdated PR was locked due to age label Jan 15, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintainer feedback Additional maintainers' opinions may be needed new formula PR adds a new formula to Homebrew/homebrew-core outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants