Updates libsodium homepage and url.

[phpeek]

• Have you followed the guidelines for contributing?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

---

It is recommended to use stable releases of libsodium - https://download.libsodium.org/doc/installation#stable-branch

Currently release is fetched via release tarball from GitHub. This PR changes that as well as updates libsodium homepage url.

I've added revision 1 to formula for bottles to be rebuilt and redistributed.

Unfortunately brew audit --strict libsodium is showing:

libsodium:
  * Stable: version 1.0.18 is redundant with version scanned from URL
  * stable: sha256 changed without the version also changing; please create an issue upstream to rule out malicious circumstances and to find out why the file changed.
Error: 2 problems in 1 formula detected

Not sure how I can fix that.

[jonchang]

• Stable: version 1.0.18 is redundant with version scanned from URL

Just remove the version line to address this audit.

[phpeek]

@jonchang Thank You. PR updated.

[Bo98]

We moved to Xcode 11.2 this week which fixes issues with libsodium so let's get the bot to rebuild it on that.

[Bo98]

@BrewTestBot test this please

[Bo98]

Did they change the archive?

==> Downloading https://download.libsodium.org/libsodium/releases/libsodium-1.0.18-stable.tar.gz
Error: An exception occurred within a child process:
  ChecksumMismatchError: SHA256 mismatch
Expected: cd191879fe6da6adf1f64801d68ced47b610e1558080a754779b32cf704ce9e3
  Actual: 957445a1d9553d5b50ef36920db647077d2b9f348f060e3703db83e5a49f9803
 Archive: /Users/brew/Library/Caches/Homebrew/downloads/a26cc1dafd7b13ee7244a873ef6d5af795e12fd1d0220dbb81eeb1a875c47909--libsodium-1.0.18-stable.tar.gz
To retry an incomplete download, remove the file above.

We can't really use this if that's going to be happening in the future.

[phpeek]

@Bo98 Looks like it.

I've had previous archive on my hard drive. I've downloaded new one and they are indeed different.

1854312 libsodium-1.0.18-stable-new.tar.gz
1852968 libsodium-1.0.18-stable.tar.gz

Looks like new archive is being rebuild and published on every push to their stable branch.

I can update hash, but wouldn't that be the problem for future maintenance of this formula ?

[Bo98]

Yeah that URL is not going to work for Homebrew. Either use https://download.libsodium.org/libsodium/releases/libsodium-1.0.18.tar.gz or go back to GitHub (not sure if there's any difference).

A revision bump is still worthwhile here either way to get it built on Xcode 11.2.

[phpeek]

Sure, I'll update PR with the archive You've mentioned. I believe this is in sync with GitHub.

[Bo98]

@BrewTestBot test this please

[Bo98]

Thank you @phpeek. Merged now.