Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gotop 3.0.0 (new formula) #49174

Closed
wants to merge 1 commit into from
Closed

gotop 3.0.0 (new formula) #49174

wants to merge 1 commit into from

Conversation

dawidd6
Copy link
Member

@dawidd6 dawidd6 commented Jan 19, 2020 •
edited

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

https://github.com/cjbassi/gotop

@chenrui333 chenrui333 added the new formula PR adds a new formula to Homebrew/homebrew-core label Jan 19, 2020
chenrui333
chenrui333 approved these changes Jan 20, 2020
View reviewed changes
Copy link
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

chenrui333
chenrui333 reviewed Jan 20, 2020
View reviewed changes
Formula/gotop.rb
end

test do
assert_equal version.to_s, shell_output("#{bin}/gotop --version").chomp
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be better to use expect syntax to improve the test part.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a TUI program, can't really test much here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lock lock bot added the outdated PR was locked due to age label Feb 25, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 25, 2020
@dawidd6 dawidd6 deleted the gotop branch March 8, 2020 19:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chenrui333 chenrui333 chenrui333 approved these changes

Assignees
No one assigned
Labels
new formula PR adds a new formula to Homebrew/homebrew-core outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dawidd6 @chenrui333