Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python: don't mention python@2 formula in caveats #49976

Merged
merged 1 commit into from
Feb 10, 2020

Conversation

dawidd6
Copy link
Member

@dawidd6 dawidd6 commented Feb 10, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

#49796

@dawidd6 dawidd6 requested a review from iMichka February 10, 2020 19:21
@SMillerDev SMillerDev added the ready to merge PR can be merged once CI is green label Feb 10, 2020
@SMillerDev
Copy link
Member

Thanks @dawidd6! Without contributions like yours it'd be impossible to keep homebrew going with the high standards that users have come to expect from the project. You can feel good knowing that you've made the world a tiny bit better for homebrew users around the world! 👍 🎉

@dawidd6 dawidd6 merged commit 7eef3e1 into Homebrew:master Feb 10, 2020
@dawidd6 dawidd6 deleted the python branch February 10, 2020 20:37
@lock lock bot added the outdated PR was locked due to age label Mar 11, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Mar 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants