Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

awscli 2.0.0 #50083

Closed
wants to merge 1 commit into from
Closed

awscli 2.0.0 #50083

wants to merge 1 commit into from

Conversation

lazzurs
Copy link
Contributor

@lazzurs lazzurs commented Feb 13, 2020

Upgrading the aws cli to version 2.0.0 from source.

There are already two PRs for this, my previous #50056 which was to
remove this and replace with a Cask which was rejected and #50029 which
has a broken build.

This changes the pip install like for the requirements to allow
installing the package of botocore as the upstream has changed the
dependencies in requirements.txt.

Tested the build and it appears to work.

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Upgrading the aws cli to version 2.0.0 from source.

There are already two PRs for this, my previous Homebrew#50056 which was to
remove this and replace with a Cask which was rejected and Homebrew#50029 which
has a broken build.

This changes the pip install like for the requirements to allow
installing the package of botocore as the upstream has changed the
dependencies in requirements.txt.

Tested the build and it appears to work.
@lazzurs lazzurs mentioned this pull request Feb 13, 2020
5 tasks
Copy link
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chenrui333 chenrui333 mentioned this pull request Feb 13, 2020
@chenrui333 chenrui333 changed the title Upgrading awscli to v2.0.0 awscli 2.0.0 Feb 13, 2020
@MikeMcQuaid
Copy link
Member

Thanks so much for your contribution! Without people like you submitting PRs we couldn't run this project. You rock, @lazzurs!

@lock lock bot added the outdated PR was locked due to age label Mar 17, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Mar 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants