valkyrie: fix build and add test #502
Conversation
| @@ -14,8 +14,14 @@ class Valkyrie < Formula | |||
| depends_on "valgrind" | |||
|
|
|||
| def install | |||
| inreplace "src/utils/vk_utils.h", "#include <iostream>", | |||
| "#include <iostream>\n#include <unistd.h>" | |||
There was a problem hiding this comment.
Can you please submit this patch to the upstream developers of this project and add a link to the upstream patch submission and explanation of why the patch is needed in a comment in the formula file. Thanks!
😉
There was a problem hiding this comment.
They've already been told they need to include that file for Solaris, but I'm happy to pile on.
There was a problem hiding this comment.
Yeh, it'd be good to submit a patch to them and have a linkable reference.
Fixes undeclared identifier errors for "getpid," "usleep", and "getuid." Also, add a test. Reported to https://bugs.kde.org/show_bug.cgi?id=362033
ilovezfs
force-pushed
the
valkyrie-undeclared-identifiers
branch
from
bb535ec
to
ec90222
Compare
|
@MikeMcQuaid upstream link added |
|
@DomT4 Is there any more idiomatic way to insert a line? |
|
Using |
|
👍 Merged. Sorry if I stepped on your toes here; was looking for a test case for a |
Fixes undeclared identifier errors for "getpid," "usleep", and "getuid."
Also, add a test.