onfluent-platform: fix confluent-platform cli #50592
Conversation
The `confluent` command is just a shell wrapper that depends on the actual binary to reside in the libexec directory of the distribution
The `confluent` shell script naively assumes it's run from the distribution directory aka the keg and it fail when run as `/usr/local/bin/confluent`. Patch the script as it's not abvious where to submit the patch upstream.
chenrui333
changed the title
confluent CLI
| rm_rf "#{libexec}/cli/linux_386" | ||
| rm_rf "#{libexec}/cli/linux_amd64" | ||
| rm_rf "#{libexec}/cli/windows_386" | ||
| rm_rf "#{libexec}/cli/windows_amd64" | ||
| end | ||
|
|
||
| test do | ||
| assert_match version.to_s, shell_output("#{bin}/kafka-broker-api-versions --version") |
There was a problem hiding this comment.
Could you improve this test to use some of the functionality of the software? Version tests rarely indicate that something is actually wrong. And especially if you're going to patch something we need a test.
| @@ -11,14 +11,36 @@ class ConfluentPlatform < Formula | |||
|
|
|||
| conflicts_with "kafka", :because => "kafka also ships with identically named Kafka related executables" | |||
|
|
|||
| patch :DATA | |||
There was a problem hiding this comment.
Has this been reported upstream? This needs a comment and a link to an upstream issue at a minimum and description of when it should be removed or how it should be updated. In an ideal world, upstream would accept the fix and we would use a patch do block to grab the patch from github.
zbeekman
added
needs response
|
I recently installed confluent-platform and I got this error : I think this pull request talks exactly about this ? |
Yepyep. Right now I don't have the time to do all the polishing required for this to be approved. I believe there is a workaround, try running it as |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?Confluent-platform install a
confluentCLI that is not really working.Two fixes are needed:
libexecfolderconfluentscript to find the keg when run from/usr/local/bin