ttyd 1.1.0 (new formula) #5310
ttyd 1.1.0 (new formula) #5310
Conversation
| end | ||
|
|
||
| test do | ||
| system "#{bin}/ttyd", "--version" |
There was a problem hiding this comment.
assert_match version.to_s, shell_output("#{bin}/ttyd --version")| head "https://github.com/tsl0922/ttyd.git" | ||
|
|
||
| depends_on "cmake" => :build | ||
| # xxd tool is from vim |
There was a problem hiding this comment.
Not necessary, remove this comment.
However, isn't /usr/bin/xxd good enough?
There was a problem hiding this comment.
No, I should use which -a xxd to find the location of xxd 😄 , will remove dependency for vim.
| def install | ||
| cmake_args = std_cmake_args + ["-DOPENSSL_ROOT_DIR=#{Formula["openssl"].opt_prefix}"] | ||
| system "cmake", ".", *cmake_args | ||
| system "make" |
There was a problem hiding this comment.
Not necessary, remove this line.
|
@zmwangx PTAL |
| sha256 "6fae4e932280f0ca430ea834f88282673351a321535acbe3725e995e83857138" | ||
| head "https://github.com/tsl0922/ttyd.git" | ||
|
|
||
| depends_on "cmake" => :build |
There was a problem hiding this comment.
According to CI failure we need to
depends_on "pkg-config" => :buildI didn't catch that locally because I have it installed.
|
Now the only problem is repo too new. I suggest we sit on this for two weeks, by which time the audit failure will resolve itself. It'll also give the project time to mature a bit more if necessary. |
|
Thanks @zmwangx. I'm OK with the 30 day rule. |
|
@zmwangx I'v updated the formula to 1.1.0 release with some new features and minor bug fixes. |
|
👍 |
|
Pulled it as it's getting releases and is more popular now. Thanks for your contribution to Homebrew! Without people like you submitting PRs we couldn't run this project. You rock! |
brew install <formula>(where<formula>is the name of the formula you're submitting)?brew audit --new-formula <formula>(after doingbrew install <formula>)?