Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zig 0.6.0 #53161

Closed
wants to merge 1 commit into from
Closed

zig 0.6.0 #53161

wants to merge 1 commit into from

Conversation

sambattalio
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

I added flags to the cmake command as instructed by the README.md on ziglang/zig here: (https://github.com/ziglang/zig/blob/master/README.md#macos).

If you have any concerns / things I should fix please let me know!

@Bo98
Copy link
Member

Bo98 commented Apr 14, 2020

The CMAKE_PREFIX_PATH shouldn't be necessary inside the formula. We already automatically add every dependency's prefix to it: https://github.com/Homebrew/brew/blob/e12da9491d2dc557636458c265196fedde34a30a/Library/Homebrew/extend/ENV/super.rb#L185-L190

It should only be necessary if you were building outside of the Homebrew environment.

@sambattalio
Copy link
Contributor Author

sambattalio commented Apr 14, 2020

Oh I can take that out then 😅 thanks! (edit: Totally see that now oops. Thanks for linking that for me.)

@sambattalio
Copy link
Contributor Author

@Bo98 just fixed based on your comment. I reran with install test and audit as well 👍

@Bo98
Copy link
Member

Bo98 commented Apr 15, 2020

Thanks!

@BrewTestBot
Copy link
Member

@Bo98 has triggered a merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants