Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asimov 0.2.0 (new formula) #55921

Closed
wants to merge 1 commit into from
Closed

Conversation

stevegrunwell
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

This is the initial submission for Asimov, a command line utility that automatically excludes development dependencies from Time Machine backups on macOS.

For example, Asimov will find node_modules/ directories and, assuming it finds an adjacent package.json file, will use the Time Machine Utility (tmutil) program to exclude the node_modules/ directory from Time Machine backups.

Fixes stevegrunwell/asimov#2.

@SMillerDev SMillerDev changed the title Asimov 0.2.0 asimov 0.2.0 (new formula) Jun 8, 2020
@SMillerDev SMillerDev added the new formula PR adds a new formula to Homebrew/homebrew-core label Jun 8, 2020
homepage "https://github.com/stevegrunwell/asimov"
url "https://github.com/stevegrunwell/asimov/archive/v0.2.0.tar.gz"
sha256 "2efb456975af066a17f928787062522de06c14eb322b2d133a8bc3a764cc5376"
revision 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be here

Comment on lines 8 to 6
# Setup HEAD support (install with --HEAD)
head "https://github.com/stevegrunwell/asimov.git", :branch => "develop"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comments aren't needed, please group all this metadata on the top of the file

Formula/asimov.rb Outdated Show resolved Hide resolved
@stevegrunwell
Copy link
Contributor Author

Feedback has been addressed, and tests now test the actual program output.

FWIW, the next release of Asimov will also include an actual test suite to make sure things are working as expected at a filesystem level.

Formula/asimov.rb Outdated Show resolved Hide resolved
Formula/asimov.rb Outdated Show resolved Hide resolved
Formula/asimov.rb Outdated Show resolved Hide resolved
@SMillerDev
Copy link
Member

Please squash all your commits into one asimov 0.2.0 (new formula)

@stevegrunwell
Copy link
Contributor Author

@SMillerDev commits have been squashed. Thank you for guiding me through my first Homebrew contribution!

Copy link
Member

@SMillerDev SMillerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stevegrunwell ! Without contributions like yours it'd be impossible to keep homebrew going with the high standards that users have come to expect from the project. You can feel good knowing that you've made the world a tiny bit better for homebrew users around the world! 👍 🎉

@BrewTestBot
Copy link
Member

:shipit: @issyl0 has triggered a merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new formula PR adds a new formula to Homebrew/homebrew-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Homebrew installation
3 participants