Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zsh-lovers: Add test block. #5678

Merged
merged 1 commit into from Oct 8, 2016

Conversation

kpearson
Copy link
Contributor

@kpearson kpearson commented Oct 8, 2016

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same formula update/change?
  • Have you built your formula locally prior to submission with brew install <formula> (where <formula> is the name of the formula you're submitting)?
  • Does your submission pass brew audit --new-formula <formula> (after doing brew install <formula>)?

I'm fairly sure using a call to man ... is considered a week test. However, all this package does is add a man page. :-)

@MikeMcQuaid
Copy link
Member

MikeMcQuaid commented Oct 8, 2016

Better than nothing! Thanks again for your contribution to Homebrew! Without people like you submitting PRs we couldn't run this project. You rock!

@MikeMcQuaid MikeMcQuaid merged commit c36231e into Homebrew:master Oct 8, 2016
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants