Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

balena-cli 12.2.0 #57082

Closed

Conversation

pranasziaukas
Copy link
Contributor

Created with brew bump-formula-pr.

@SMillerDev
Copy link
Member

The last update was 2 days ago, either we need to postpone this PR (and write an audit to enforce the rule) or remove the comment. @Homebrew/core opinions?

@pranasziaukas
Copy link
Contributor Author

To make things more nuanced, please note that updates ain't equal. Following semantic versioning, is it worth prioritizing major or minor releases compared to patches?
Also, is it ethical to withhold releases given that they might be fixing security vulnerabilities?

@SMillerDev
Copy link
Member

Also, is it ethical to withhold releases given that they might be fixing security vulnerabilities?

With a release a day you're using so much CI resources that you're probably regularly delaying security updates to things like Go and OpenSSL. Any CI time can only be used once and there's almost always a queue.

@MikeMcQuaid
Copy link
Member

Also, is it ethical to withhold releases given that they might be fixing security vulnerabilities?

Does this release fix security vulnerabilities?

@pranasziaukas
Copy link
Contributor Author

Cool. Please note that I'm not trying to force any opinion rather than just to add to the potential discussion.

@pranasziaukas
Copy link
Contributor Author

Does this release fix security vulnerabilities?

I don't know because I'm not a developer of balena CLI.

@pranasziaukas
Copy link
Contributor Author

Overall, this formula has been updated 11 times this month already so it's obvious that the current limits are disregarded.

Feel free to decide on the throttling mechanism that works or remove the comment.

@alebcay
Copy link
Member

alebcay commented Jun 29, 2020

I usually group up some fast-moving formulae like this and do one big push of them when CI's quiet (for me, usually like midnight-2am local time - late enough to dodge US PRs and early enough to dodge most Europe PRs).

It might be easier changing the rule to "bump only on multiples of 10" or something like that. That way contributors don't have to dig through Git history to check. I think that's also probably easier/faster to audit than checking the last time of modification.

@MikeMcQuaid
Copy link
Member

Does this release fix security vulnerabilities?

I don't know because I'm not a developer of balena CLI.

I'm not sure it was relevant to bring them up, then.

It might be easier changing the rule to "bump only on multiples of 10" or something like that. That way contributors don't have to dig through Git history to check. I think that's also probably easier/faster to audit than checking the last time of modification.

Yes, we already have a mechanism for this:
https://github.com/Homebrew/brew/blob/a1ba14255f789e4b20f796ed9ae23da3d47e8151/Library/Homebrew/dev-cmd/audit.rb#L553-L558

We should do the same thing here and remove the comment (and any on any similar formulae).

pranasziaukas added a commit to pranasziaukas/brew that referenced this pull request Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants