Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pforth 28 (new formula) #57250

Closed
wants to merge 1 commit into from
Closed

Conversation

SeekingMeaning
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@Rylan12 Rylan12 added the new formula PR adds a new formula to Homebrew/homebrew-core label Jul 1, 2020
@chenrui333
Copy link
Member

license audit failure which is expected (Homebrew/brew#7874)

@chenrui333
Copy link
Member

@SeekingMeaning thanks for the PR, can you rebase to the master? We have sorted out the CI issue. Thanks!

class Pforth < Formula
desc "Portable ANS-like Forth written in ANSI C"
homepage "http://www.softsynth.com/pforth/"
url "https://github.com/philburk/pforth/archive/d71efe1792a1414a5b102ae8e69f3913c70aa8b0.tar.gz"
Copy link
Member

@chenrui333 chenrui333 Jul 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is interesting, why does the upstream not like to make a release tag for the commit?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm should I ask about this in an issue on their repo?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we require a tagged commit to release

Copy link
Member

@chenrui333 chenrui333 Jul 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another interesting thing to call out is the repo does not have OSS license either.

@chenrui333
Copy link
Member

Going to mark the PR as do not merge due to the two concerns that we raised.

@SMillerDev
Copy link
Member

Since it doesn't match https://docs.brew.sh/Acceptable-Formulae#stable-versions and https://docs.brew.sh/Acceptable-Formulae#we-dont-like-binary-formulae I'm just closing this.

@SMillerDev SMillerDev closed this Jul 4, 2020
@SeekingMeaning SeekingMeaning deleted the patch-5 branch July 4, 2020 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new formula PR adds a new formula to Homebrew/homebrew-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants