-
-
Notifications
You must be signed in to change notification settings - Fork 12.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pforth 28 (new formula) #57250
pforth 28 (new formula) #57250
Conversation
license audit failure which is expected (Homebrew/brew#7874) |
@SeekingMeaning thanks for the PR, can you rebase to the master? We have sorted out the CI issue. Thanks! |
class Pforth < Formula | ||
desc "Portable ANS-like Forth written in ANSI C" | ||
homepage "http://www.softsynth.com/pforth/" | ||
url "https://github.com/philburk/pforth/archive/d71efe1792a1414a5b102ae8e69f3913c70aa8b0.tar.gz" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is interesting, why does the upstream not like to make a release tag for the commit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm should I ask about this in an issue on their repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we require a tagged commit to release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another interesting thing to call out is the repo does not have OSS license either.
Going to mark the PR as |
Since it doesn't match https://docs.brew.sh/Acceptable-Formulae#stable-versions and https://docs.brew.sh/Acceptable-Formulae#we-dont-like-binary-formulae I'm just closing this. |
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install <formula>
)?