Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ansible@2.8 depends on python (3.8) but should on python@3.7 #57720

Closed
wants to merge 1 commit into from
Closed

ansible@2.8 depends on python (3.8) but should on python@3.7 #57720

wants to merge 1 commit into from

Conversation

arvenil
Copy link
Contributor

@arvenil arvenil commented Jul 9, 2020

Fixes #57719

@SMillerDev
Copy link
Member

Could you add revision 1, that'll make sure everyone gets this update.

@arvenil
Update ansible@2.8.rb
9d0c28d 
Depends on `python@3.7` instead of `python` (which is now python 3.8).
@arvenil
Copy link
Contributor Author

arvenil commented Jul 9, 2020

@SMillerDev Thanks, I've bumped it to revision 2, should be correct now?

@SMillerDev
Copy link
Member

It should be, but something is breaking CI.

@Rylan12
Copy link
Member

Rylan12 commented Jul 9, 2020 •
edited

The build issue should be fixed in Homebrew/brew#7959

@arvenil
Copy link
Contributor Author

arvenil commented Jul 9, 2020 •
edited

@Rylan12 Thank you again! Exactly I just debugged that virtualenv_install_with_resources fails, then I found out issue Homebrew/brew#6858 and then I noticed missing python@3.7.
Locally I've used virtualenv_install_with_resources using: "python3.8" and it works! Thank you again!

@Rylan12
Copy link
Member

Rylan12 commented Jul 9, 2020 •
edited

No problem (but I shouldn't take all the credit)! The PR has been merged so I'm going to give this another go

@Rylan12
Copy link
Member

Rylan12 commented Jul 9, 2020

Thanks for your first contribution to Homebrew, @arvenil! 🥳 🎉🥇

Thanks to contributors like you, we're able to maintain Homebrew to the high standards that users expect. Thanks again for your work! 👍

@Rylan12 Rylan12 closed this in 79180c5 Jul 9, 2020
@iMichka iMichka mentioned this pull request Jul 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rylan12 Rylan12 Rylan12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ansible@2.8 depends on python@3.8 but should on python@3.7
3 participants
@arvenil @SMillerDev @Rylan12