Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake 3.18.0 #58002

Closed
wants to merge 1 commit into from
Closed

cmake 3.18.0 #58002

wants to merge 1 commit into from

Conversation

yurikoles
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Signed-off-by: Yurii Kolesnykov <root@yurikoles.com>
@yurikoles
Copy link
Contributor Author

==> FAILED
Error: 1 problem in 1 formula detected
cmake:
  * Emacs Lisp files were linked directly to /usr/local/share/emacs/site-lisp
    This may cause conflicts with other packages.
    They should instead be installed into:
      /usr/local/opt/cmake/share/emacs/site-lisp/cmake
    
    The offending files are:
      /usr/local/opt/cmake/share/emacs/site-lisp/cmake-mode.el

I don't get it, folder are the same, don't it?

@Bo98
Copy link
Member

Bo98 commented Jul 15, 2020

It is wanting /usr/local/opt/cmake/share/emacs/site-lisp/cmake/cmake-lisp.el.

Homebrew already puts it in the right place with elisp.install but it looks like CMake 3.18 now installs another copy in the unwanted location.

Maybe try change the elisp.install line to mv share/"emacs/site-lisp/cmake-mode.el", elisp/"cmake-mode.el"

@yurikoles
Copy link
Contributor Author

I give up, I don't know how to fix it and it uses a lot of time to build, since I can't use ccache with brew.

@yurikoles yurikoles closed this Jul 20, 2020
@yurikoles yurikoles deleted the cmake-3.18 branch July 20, 2020 07:50
@hjmallon
Copy link
Contributor

hjmallon commented Jul 21, 2020

I made https://gitlab.kitware.com/cmake/cmake/-/issues/20993 to try to find someone who knows enough about emacs to see what the solution is.

@Bo98
Copy link
Member

Bo98 commented Jul 21, 2020

I presume the suggestion I made didn't work then.

That said, it would be good if CMake offered a bit of flexibility in install locations here.

@hjmallon
Copy link
Contributor

I have not tried your suggestion yet, but I have found the commit in cmake that changes behaviour https://gitlab.kitware.com/cmake/cmake/commit/2642f432ef05d083da66c0b24cd10d655f951186. Is that useful?

@Bo98
Copy link
Member

Bo98 commented Jul 21, 2020

Our policy is ${CMAKE_XDGDATA_DIR}/emacs/site-lisp/cmake. This isn't some Homebrew-specific thing - I know Fedora/Red Hat also install there. Debian doesn't.

@Bo98
Copy link
Member

Bo98 commented Jul 21, 2020

I've opened #58306 to continue this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants