Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

caffe: fix protobuf issue #58210

Closed
wants to merge 1 commit into from
Closed

caffe: fix protobuf issue #58210

wants to merge 1 commit into from

Conversation

ankane
Copy link
Contributor

@ankane ankane commented Jul 18, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

A change in Protobuf 3.12.3 (protocolbuffers/protobuf#7496) is causing an error when trying to build projects with Caffe.

/usr/local/opt/caffe/include/caffe/proto/caffe.pb.h:49:51: error: no type named 'AuxillaryParseTableField' in namespace 'google::protobuf::internal'; did you mean 'AuxiliaryParseTableField'?
  static const ::PROTOBUF_NAMESPACE_ID::internal::AuxillaryParseTableField aux[]
               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~
                                                  AuxiliaryParseTableField
/usr/local/include/google/protobuf/generated_message_table_driven.h:141:7: note: 'AuxiliaryParseTableField' declared here

There isn't an error when building from source, so bumping the revision should fix it (last revision was before Protobuf 3.12.3 was released).

@chenrui333
Copy link
Member

@ankane, looks like you need a rebase. change lgtm!

@Bo98
Copy link
Member

Bo98 commented Jul 20, 2020

Is this still a problem after #58229?

@ankane
Copy link
Contributor Author

ankane commented Jul 20, 2020

That fixed it as well, thanks @Bo98!

@ankane ankane closed this Jul 20, 2020
@Bo98
Copy link
Member

Bo98 commented Jul 20, 2020

The changes are going to happen sometime in the future - it might be a good idea, if possible, to make the caffe test detect the breakage.

@ankane
Copy link
Contributor Author

ankane commented Jul 21, 2020

I'm not sure of the best way to test this one (was a dependency for another project). I imagine anytime there's a breaking change with protobuf, any formulas that generate protocol buffers will need to be updated.

@Bo98 Bo98 mentioned this pull request Jul 29, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants