Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lame: update stable url format, add license #59319

Merged
merged 1 commit into from Aug 8, 2020

Conversation

samford
Copy link
Member

@samford samford commented Aug 8, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

The stable URL for lame is using a format that isn't compatible with brew livecheck's Sourceforge strategy. This appears to be the only SourceForge URL that uses this different format. The others use a URL starting with https://downloads.sourceforge.net/project/ instead of https://downloads.sourceforge.net/sourceforge/.

This updates the stable URL to bring it in line with the other SourceForge URLs, while also making it compatible with livecheck's Sourceforge strategy.

@BrewTestBot BrewTestBot added the missing license Formula has a missing license which should be added label Aug 8, 2020
@samford samford force-pushed the update-lame-stable-url-format branch from c950a79 to f3cd33a Compare August 8, 2020 04:26
@samford samford changed the title lame: update stable url format lame: update stable url format, add license Aug 8, 2020
@samford samford removed the missing license Formula has a missing license which should be added label Aug 8, 2020
@samford
Copy link
Member Author

samford commented Aug 8, 2020

I added the license information from the COPYING file found in the lame SVN trunk here: https://sourceforge.net/p/lame/svn/HEAD/tree/trunk/lame/COPYING

@dtrodrigues
Copy link
Member

dtrodrigues commented Aug 8, 2020

Can this be made into a style check for future SourceForge URLs?

@samford
Copy link
Member Author

samford commented Aug 8, 2020

Can this be made into a style check for future SourceForge URLs?

Yep, after I read your comment I worked on adding a couple cases to the existing urls RuboCops for SourceForge URLs and I'll create a Homebrew/brew PR for the changes tomorrow.

@chenrui333 chenrui333 merged commit 50be1b4 into Homebrew:master Aug 8, 2020
@samford samford deleted the update-lame-stable-url-format branch August 8, 2020 13:00
@samford samford added the license License PRs label Nov 1, 2020
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 2, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
license License PRs outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants