Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x265: fix upstream repo url #59866

Closed
wants to merge 1 commit into from

Conversation

jnozsc
Copy link
Contributor

@jnozsc jnozsc commented Aug 19, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

fix Homebrew/brew#8393

some context for reviewers, bitbucket sunsets mercurial support, all mercurial repos are not available any more https://bitbucket.org/blog/sunsetting-mercurial-support-in-bitbucket

@gromgit
Copy link
Member

gromgit commented Aug 19, 2020

You may want to change the homepage URL too: https://www.videolan.org/developers/x265.html

@BrewTestBot BrewTestBot added the deprecated license Formula uses a deprecated SPDX license which should be updated label Aug 19, 2020
@jnozsc
Copy link
Contributor Author

jnozsc commented Aug 19, 2020

The website seems a little misleading that it points to a hg repo.

Based on the maillist, the hg repo on hg.videolan.org is a mirror repo, not main repo https://mailman.videolan.org/pipermail/x265-devel/2020-June/013041.html

I suggest to keep the git repo as the homepage, at least before x265 team update the website you mentioned

@BrewTestBot BrewTestBot removed the deprecated license Formula uses a deprecated SPDX license which should be updated label Aug 19, 2020
@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@jnozsc jnozsc deleted the fix-x265-bitbucket-hg branch August 20, 2020 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to install ffmpeg. Failed to download resource "x265".
4 participants