Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auditbeat: migrate to python@3.9 #62243

Closed
wants to merge 1 commit into from

Conversation

fxcoudert
Copy link
Member

As part of the Python 3.9 migration (#62201).

This formula is independent from the all other Python formulas (if I didn't screw up my script or my logic)

Do not merge before the next Brew tag ships, expected on Monday 2020-10-12

@BrewTestBot BrewTestBot added go Go use is a significant feature of the PR or issue python Python use is a significant feature of the PR or issue and removed do not merge labels Oct 7, 2020
@fxcoudert
Copy link
Member Author

    The headers or library files could not be found for zlib,
    a required dependency when compiling Pillow from source.
    
    Please see the install instructions at:
       https://pillow.readthedocs.io/en/latest/installation.html

@yous
Copy link
Contributor

yous commented Oct 14, 2020

Could you try this:

diff --git a/Formula/auditbeat.rb b/Formula/auditbeat.rb
index f54e3cfad6..c0d234057f 100644
--- a/Formula/auditbeat.rb
+++ b/Formula/auditbeat.rb
@@ -15,8 +15,10 @@ class Auditbeat < Formula
     sha256 "484ef0e1fab73cf7431f2867e1a4e69d055eb71855d0748ea31c27dfab401eab" => :high_sierra
   end
 
+  depends_on "freetype" => :build
   depends_on "go" => :build
   depends_on "python@3.9" => :build
+  depends_on "zlib" => :build
 
   resource "virtualenv" do
     url "https://files.pythonhosted.org/packages/d4/0c/9840c08189e030873387a73b90ada981885010dd9aea134d6de30cd24cb8/virtualenv-15.1.0.tar.gz"
@@ -55,7 +57,7 @@ class Auditbeat < Formula
 
       system "make", "mage"
       # prevent downloading binary wheels during python setup
-      system "make", "PIP_INSTALL_PARAMS=--no-binary :all", "python-env"
+      system "make", "PIP_INSTALL_PARAMS=--use-pep517 --no-binary :all:", "python-env"
       system "mage", "-v", "build"
       system "mage", "-v", "update"
 

--no-binary :all actually means nothing as the argument should be :all:. It fails even though, and --use-pep517 is needed.

@fxcoudert
Copy link
Member Author

Superseded by #63381

@fxcoudert fxcoudert closed this Oct 23, 2020
@fxcoudert fxcoudert deleted the py39_auditbeat branch October 23, 2020 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Go use is a significant feature of the PR or issue python Python use is a significant feature of the PR or issue python-3.9-migration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants