ios-class-guard: add livecheck #63925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rui Chen <rui@meetup.com>
chenrui333
added
livecheck
BrewTestBot
added
the
deprecated license
samford
requested changes
Nov 1, 2020
There was a problem hiding this comment.
I saw this formula earlier but couldn't decide on a satisfactory way to deal with the tag situation. I think all we can do right now is what you're doing here, where we restrict matching to 0.x versions. I don't like doing this because it increases our maintenance burden but we don't have any other options right now (e.g., there's no "latest" release).
I added a suggested comment that explains the situation and makes it clear that the check will need to be updated if the software ever reaches 1.x releases.
Co-authored-by: Sam Ford <1584702+samford@users.noreply.github.com>
samford
approved these changes
Nov 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ios-class-guard: add livecheck