Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opam: depend on gpatch #64301

Closed
wants to merge 1 commit into from
Closed

opam: depend on gpatch #64301

wants to merge 1 commit into from

Conversation

avsm
Copy link
Contributor

@avsm avsm commented Nov 7, 2020

opam depends on GNU patch for some of its operations (ocaml/opam#3639)

Signed-off-by: Anil Madhavapeddy anil@recoil.org

@avsm
opam: depend on gpatch
95950b6 
opam depends on GNU patch for some of its operations (ocaml/opam#3639)

Signed-off-by: Anil Madhavapeddy <anil@recoil.org>
@BrewTestBot BrewTestBot added deprecated license Formula uses a deprecated SPDX license which should be updated ocaml OCaml use is a significant feature of the PR or issue labels Nov 7, 2020
@avsm avsm mentioned this pull request Nov 7, 2020
Merged
johnwhitington added a commit to johnwhitington/opam that referenced this pull request Nov 7, 2020
@johnwhitington
Reorder options, fix brew instructions, spelling
71a62a2 
This PR reflects three lessons learned when writing the new ocaml.org "Up and Running" guide ocaml/ocaml.org#1165 :

1) Having the binary distribution at the top of this page, when it is not the recommended installation mechanism for most users, is confusing.
2) Brew will shortly be updated Homebrew/homebrew-core#64301 to make opam depend on gpatch, thus removing this instruction from the OS X instructions.
3) OSX is now spelled macOS
This was referenced Nov 7, 2020
Merged
Open
@chenrui333
Copy link
Member

Thanks @avsm!!

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@avsm avsm deleted the patch-1 branch November 9, 2020 06:51
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 11, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chenrui333 chenrui333 chenrui333 approved these changes

Assignees
No one assigned
Labels
deprecated license Formula uses a deprecated SPDX license which should be updated ocaml OCaml use is a significant feature of the PR or issue outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@avsm @chenrui333 @BrewTestBot